Bug 151426 - A window with a hung tab waits 5s before becoming active
Summary: A window with a hung tab waits 5s before becoming active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-18 18:06 PST by Geoffrey Garen
Modified: 2015-11-20 15:11 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2015-11-18 18:17 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-11-18 18:06:00 PST 
A window with a hung tab waits 5s before becoming active
Comment 1 Geoffrey Garen 2015-11-18 18:17:32 PST 
Created attachment 265819 [details]
Patch
Comment 2 Anders Carlsson 2015-11-19 10:58:46 PST 
Comment on attachment 265819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265819&action=review

> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1163
> +    if (!mightBeginDragWhileInactive())
>          return false;

Should we check mightBeginScrollWhileInactive here too?
Comment 3 Geoffrey Garen 2015-11-19 11:28:13 PST 
Comment on attachment 265819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265819&action=review

>> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1163
>>          return false;
> 
> Should we check mightBeginScrollWhileInactive here too?

According to TextEdit's behavior, a scrollbar scroll that begins while the window is inactive will activate the window. In other words, scrolls do not delay window ordering. So, there's no need to check mightBeginScrollWhileInactive here.
Comment 4 Geoffrey Garen 2015-11-20 15:10:59 PST 
Comment on attachment 265819 [details]
Patch

Clearing flags on attachment: 265819

Committed r192703: <http://trac.webkit.org/changeset/192703>
Comment 5 Geoffrey Garen 2015-11-20 15:11:02 PST 
All reviewed patches have been landed.  Closing bug.