Bug 151423 – FTL should be able to compile a small function with B3

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

...

[Filip Pizlo]

Created attachment 265805 [details]
work in progress

[Filip Pizlo]

Created attachment 265809 [details]
work in progress

[Benjamin Poulain]

Created attachment 265821 [details]
Patch

[WebKit Commit Bot]

Attachment 265821 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9061:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 265821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265821&action=review

I think that we can have a better story for upsilons.  I think that having anchor() create one for you, and then making ValueFromBlock hold onto it, is the most natural.

> Source/JavaScriptCore/ftl/FTLB3Output.h:368
> +    ValueFromBlock anchor(LValue value)
> +    {
> +        return ValueFromBlock(value, m_block);
> +    }

Either this should create an Upsilon for you by simply appending it to m_block...

> Source/JavaScriptCore/ftl/FTLB3Output.h:407
> +inline void Output::addIncomingToPhi(LValue phi, ValueFromBlock value)
> +{
> +    value.value()->as<B3::UpsilonValue>()->setPhi(phi);
> +}

... or this should create an Upsilon for you by appending it to the block that your value came from.

[Benjamin Poulain]

Created attachment 265824 [details]
Patch

[WebKit Commit Bot]

Attachment 265824 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9061:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 265824 [details]
Patch

Clearing flags on attachment: 265824

Committed r192605: <http://trac.webkit.org/changeset/192605>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.