Bug 151420 – Simple line layout: Add word-spacing support.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

SSIA.

[zalan]

Created attachment 265806 [details]
Patch

[Build Bot]

Comment on attachment 265806 [details]
Patch

Attachment 265806 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/447559

New failing tests:
fast/text/word-space.html
fast/text/basic/004.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
fast/text/atsui-negative-spacing-features.html
css1/text_properties/word_spacing.html
fast/text/atsui-spacing-features.html
fast/css/word-space-extra.html
svg/custom/svg-fonts-word-spacing.html
fast/text/basic/005.html

[Build Bot]

Created attachment 265811 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 265806 [details]
Patch

Attachment 265806 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/447545

New failing tests:
fast/text/word-space.html
fast/text/basic/004.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
fast/text/atsui-negative-spacing-features.html
css1/text_properties/word_spacing.html
fast/text/atsui-spacing-features.html
fast/css/word-space-extra.html
svg/custom/svg-fonts-word-spacing.html
fast/text/basic/005.html

[Build Bot]

Created attachment 265813 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 265806 [details]
Patch

Attachment 265806 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/447632

New failing tests:
fast/text/word-space.html
fast/text/basic/004.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
fast/text/atsui-negative-spacing-features.html
css1/text_properties/word_spacing.html
fast/text/atsui-spacing-features.html
fast/css/word-space-extra.html
svg/custom/svg-fonts-word-spacing.html
fast/text/basic/005.html

[Build Bot]

Created attachment 265816 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[zalan]

Created attachment 265877 [details]
Patch

[Antti Koivisto]

Comment on attachment 265877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265877&action=review

> Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp:50
> +    if (style.wordSpacing().isPercent())
> +        wordSpacing = spaceWidth * style.wordSpacing().percent() / 100;
> +    else
> +        wordSpacing = style.wordSpacing().value();

I think this could use floatValueForLength or similar.

[zalan]

Created attachment 265886 [details]
Patch

[Build Bot]

Comment on attachment 265886 [details]
Patch

Attachment 265886 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/451194

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 265890 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[zalan]

Created attachment 265892 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 265892 [details]
Patch

Clearing flags on attachment: 265892

Committed r192660: <http://trac.webkit.org/changeset/192660>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.