Bug 151420 - Simple line layout: Add word-spacing support.
Summary: Simple line layout: Add word-spacing support.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-18 16:07 PST by zalan
Modified: 2015-11-19 14:29 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.72 KB, patch)
2015-11-18 16:28 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.91 MB, application/zip)
2015-11-18 17:00 PST, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.97 MB, application/zip)
2015-11-18 17:03 PST, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.94 MB, application/zip)
2015-11-18 17:23 PST, Build Bot
no flags Details
Patch (27.71 KB, patch)
2015-11-19 11:51 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (27.71 KB, patch)
2015-11-19 12:53 PST, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (670.52 KB, application/zip)
2015-11-19 13:05 PST, Build Bot
no flags Details
Patch (27.67 KB, patch)
2015-11-19 13:19 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-11-18 16:07:59 PST
SSIA.
Comment 1 zalan 2015-11-18 16:28:27 PST
Created attachment 265806 [details]
Patch
Comment 2 Build Bot 2015-11-18 17:00:26 PST
Comment on attachment 265806 [details]
Patch

Attachment 265806 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/447559

New failing tests:
fast/text/word-space.html
fast/text/basic/004.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
fast/text/atsui-negative-spacing-features.html
css1/text_properties/word_spacing.html
fast/text/atsui-spacing-features.html
fast/css/word-space-extra.html
svg/custom/svg-fonts-word-spacing.html
fast/text/basic/005.html
Comment 3 Build Bot 2015-11-18 17:00:29 PST
Created attachment 265811 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2015-11-18 17:03:42 PST
Comment on attachment 265806 [details]
Patch

Attachment 265806 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/447545

New failing tests:
fast/text/word-space.html
fast/text/basic/004.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
fast/text/atsui-negative-spacing-features.html
css1/text_properties/word_spacing.html
fast/text/atsui-spacing-features.html
fast/css/word-space-extra.html
svg/custom/svg-fonts-word-spacing.html
fast/text/basic/005.html
Comment 5 Build Bot 2015-11-18 17:03:45 PST
Created attachment 265813 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2015-11-18 17:23:37 PST
Comment on attachment 265806 [details]
Patch

Attachment 265806 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/447632

New failing tests:
fast/text/word-space.html
fast/text/basic/004.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html
fast/text/atsui-negative-spacing-features.html
css1/text_properties/word_spacing.html
fast/text/atsui-spacing-features.html
fast/css/word-space-extra.html
svg/custom/svg-fonts-word-spacing.html
fast/text/basic/005.html
Comment 7 Build Bot 2015-11-18 17:23:42 PST
Created attachment 265816 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 zalan 2015-11-19 11:51:56 PST
Created attachment 265877 [details]
Patch
Comment 9 Antti Koivisto 2015-11-19 11:57:35 PST
Comment on attachment 265877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265877&action=review

> Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp:50
> +    if (style.wordSpacing().isPercent())
> +        wordSpacing = spaceWidth * style.wordSpacing().percent() / 100;
> +    else
> +        wordSpacing = style.wordSpacing().value();

I think this could use floatValueForLength or similar.
Comment 10 zalan 2015-11-19 12:53:00 PST
Created attachment 265886 [details]
Patch
Comment 11 Build Bot 2015-11-19 13:05:08 PST
Comment on attachment 265886 [details]
Patch

Attachment 265886 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/451194

Number of test failures exceeded the failure limit.
Comment 12 Build Bot 2015-11-19 13:05:11 PST
Created attachment 265890 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 zalan 2015-11-19 13:19:31 PST
Created attachment 265892 [details]
Patch
Comment 14 WebKit Commit Bot 2015-11-19 14:29:26 PST
Comment on attachment 265892 [details]
Patch

Clearing flags on attachment: 265892

Committed r192660: <http://trac.webkit.org/changeset/192660>
Comment 15 WebKit Commit Bot 2015-11-19 14:29:31 PST
All reviewed patches have been landed.  Closing bug.