Bug 151414 - Progress towards implementing Downloads with NETWORK_SESSION
Summary: Progress towards implementing Downloads with NETWORK_SESSION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-18 15:31 PST by Alex Christensen
Modified: 2015-11-19 05:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (52.00 KB, patch)
2015-11-18 15:46 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (52.03 KB, patch)
2015-11-18 16:02 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-11-18 15:31:27 PST 
Progress towards implementing Downloads with NETWORK_SESSION
Comment 1 Alex Christensen 2015-11-18 15:46:00 PST 
Created attachment 265793 [details]
Patch
Comment 2 Brady Eidson 2015-11-18 15:53:34 PST 
Comment on attachment 265793 [details]
Patch

More #if USE(NETWORK_SESSION)  :(
Comment 3 Alex Christensen 2015-11-18 16:02:56 PST 
Created attachment 265797 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-18 17:17:20 PST 
Comment on attachment 265797 [details]
Patch

Clearing flags on attachment: 265797

Committed r192601: <http://trac.webkit.org/changeset/192601>
Comment 5 WebKit Commit Bot 2015-11-18 17:17:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogonác 2015-11-18 23:56:19 PST 
(In reply to comment #4)
> Comment on attachment 265797 [details]
> Patch
> 
> Clearing flags on attachment: 265797
> 
> Committed r192601: <http://trac.webkit.org/changeset/192601>

It broke the Apple Windows and WinCairo build.
Comment 7 Csaba Osztrogonác 2015-11-19 05:00:08 PST 
fix landed in http://trac.webkit.org/changeset/192623