Bug 151411 – js/regress/script-tests/ftl-object-sub.js needs more iterations for benchmarking.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Previously, in r192392, I reduced the test iteration count to make the layout test happy and not time out.  Unfortunately, this defeats the use of this test for benchmarking.  I've changed it to now use different iteration counts depending on who is running it.

[Mark Lam]

Created attachment 265785 [details]
proposed patch.

[Filip Pizlo]

Comment on attachment 265785 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=265785&action=review

> LayoutTests/js/regress/script-tests/ftl-object-sub.js:33
> +    // We're doing a benchmark run and need more iterations.
> +    iterations = 100000;
> +    expectedResult = 2000020;

run-jsc-stress-tests will take this path, so you're not getting what you intended.

[Mark Lam]

Created attachment 265810 [details]
patch 2: reworded comments, and change run config to runFTLNoCJIT only.

[Mark Lam]

Comment on attachment 265810 [details]
patch 2: reworded comments, and change run config to runFTLNoCJIT only.

Cancelling commit.  Will land manually.

[Mark Lam]

Thanks for the review.  Landed in r192663: <http://trac.webkit.org/r192663>.