Bug 151404 - FTL OSR Exits that are exception handlers should not have two different entrances. Instead, we should have two discrete OSR exits that do different things.
Summary: FTL OSR Exits that are exception handlers should not have two different entra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-18 14:02 PST by Saam Barati
Modified: 2015-11-30 16:55 PST (History)
10 users (show)

See Also:

Attachments
patch (25.30 KB, patch)
2015-11-30 16:30 PST, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-11-18 14:02:43 PST 
...
Comment 1 Saam Barati 2015-11-30 16:30:25 PST 
Created attachment 266298 [details]
patch
Comment 2 Saam Barati 2015-11-30 16:41:45 PST 
Comment on attachment 266298 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266298&action=review

> Source/JavaScriptCore/ftl/FTLExceptionHandlerManager.cpp:95
>      auto findResult = m_map.find(stackmapRecordIndex);
>      if (findResult == m_map.end())

These should be m_callOperationMap and I've changed to that locally.
Comment 3 Saam Barati 2015-11-30 16:55:59 PST 
landed in:
http://trac.webkit.org/changeset/192845