Bug 151387 - [WinCairo][MediaFoundation] The main thread can sometimes be blocked forever when ending a media session.
Summary: [WinCairo][MediaFoundation] The main thread can sometimes be blocked forever ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-18 07:29 PST by peavo
Modified: 2015-11-18 10:29 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.19 KB, patch)
2015-11-18 07:38 PST, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-11-18 07:29:24 PST
This happens because the main thread is waiting for the sample scheduler thread to finish, but sometimes it never does.
This can be resolved by emptying the scheduler's sample queue before requesting the scheduler thread to finish.
This will make sure the scheduler thread returns to it's main loop quickly, and can handle the termination request.
Comment 1 peavo 2015-11-18 07:38:12 PST
Created attachment 265745 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-18 10:25:02 PST
Comment on attachment 265745 [details]
Patch

Clearing flags on attachment: 265745

Committed r192578: <http://trac.webkit.org/changeset/192578>
Comment 3 WebKit Commit Bot 2015-11-18 10:25:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 peavo 2015-11-18 10:29:13 PST
Thanks for reviewing!