RESOLVED FIXED 151377
Web Inspector: Watch Expressions details section should use NavigationBar 
https://bugs.webkit.org/show_bug.cgi?id=151377
Summary Web Inspector: Watch Expressions details section should use NavigationBar
Matt Baker
Reported 2015-11-17 19:07:59 PST
* SUMMARY Watch Expressions details section should use NavigationBar. DOM elements for the add, remove and refresh buttons are currently added manually. The refresh and remove buttons should be disabled if no watch expressions exist.
Attachments
[Patch] Proposed Fix (8.91 KB, patch)
2015-11-17 19:37 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Image] UI with navbar (43.80 KB, image/png)
2015-11-17 19:39 PST, Matt Baker 		no flags
Details
UI looks weird (80.31 KB, image/png)
2015-11-18 15:40 PST, Blaze Burg 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-17 19:08:31 PST
<rdar://problem/23588013>
Matt Baker
Comment 2 2015-11-17 19:37:36 PST
Created attachment 265730 [details] [Patch] Proposed Fix
Matt Baker
Comment 3 2015-11-17 19:39:05 PST
Created attachment 265731 [details] [Image] UI with navbar
WebKit Commit Bot
Comment 4 2015-11-18 13:36:45 PST
Comment on attachment 265730 [details] [Patch] Proposed Fix Clearing flags on attachment: 265730 Committed r192584: <http://trac.webkit.org/changeset/192584>
WebKit Commit Bot
Comment 5 2015-11-18 13:36:48 PST
All reviewed patches have been landed. Closing bug.
Blaze Burg
Comment 6 2015-11-18 15:40:45 PST
Created attachment 265790 [details] UI looks weird This patch looks wrong on my machine (10.11.2)
Blaze Burg
Comment 7 2015-11-18 15:41:08 PST
Reopening.
Blaze Burg
Comment 8 2015-11-18 16:09:33 PST
(In reply to comment #7) > Reopening. Never mind, they were just landed in the wrong order.
Note You need to log in before you can comment on or make changes to this bug.