Bug 151377 - Web Inspector: Watch Expressions details section should use NavigationBar
Summary: Web Inspector: Watch Expressions details section should use NavigationBar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on: 151373
Blocks:
  Show dependency tree / graph
 
Reported: 2015-11-17 19:07 PST by Matt Baker
Modified: 2015-11-18 16:09 PST (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (8.91 KB, patch)
2015-11-17 19:37 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] UI with navbar (43.80 KB, image/png)
2015-11-17 19:39 PST, Matt Baker 		no flags Details
UI looks weird (80.31 KB, image/png)
2015-11-18 15:40 PST, BJ Burg 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-11-17 19:07:59 PST 
* SUMMARY
Watch Expressions details section should use NavigationBar. DOM elements for the add, remove and refresh buttons are currently added manually. The refresh and remove buttons should be disabled if no watch expressions exist.
Comment 1 Radar WebKit Bug Importer 2015-11-17 19:08:31 PST 
<rdar://problem/23588013>
Comment 2 Matt Baker 2015-11-17 19:37:36 PST 
Created attachment 265730 [details]
[Patch] Proposed Fix
Comment 3 Matt Baker 2015-11-17 19:39:05 PST 
Created attachment 265731 [details]
[Image] UI with navbar
Comment 4 WebKit Commit Bot 2015-11-18 13:36:45 PST 
Comment on attachment 265730 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 265730

Committed r192584: <http://trac.webkit.org/changeset/192584>
Comment 5 WebKit Commit Bot 2015-11-18 13:36:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 BJ Burg 2015-11-18 15:40:45 PST 
Created attachment 265790 [details]
UI looks weird

This patch looks wrong on my machine (10.11.2)
Comment 7 BJ Burg 2015-11-18 15:41:08 PST 
Reopening.
Comment 8 BJ Burg 2015-11-18 16:09:33 PST 
(In reply to comment #7)
> Reopening.

Never mind, they were just landed in the wrong order.