Bug 151376 - run-webkit-tests should not truncate persistent lines
Summary: run-webkit-tests should not truncate persistent lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-17 18:00 PST by Alexey Proskuryakov
Modified: 2015-11-17 22:27 PST (History)
4 users (show)

See Also:


Attachments
proposed fix (3.05 KB, patch)
2015-11-17 18:08 PST, Alexey Proskuryakov
koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-11-17 18:00:28 PST
For whatever reason (or more precisely, to match ninja behavior), run-webkit-tests truncates its output, so that progress messages fit in one line. This is sort of OK for transient progress lines that get erased immediately, but not for what remains on the screen, especially for failures.

rdar://problem/23162775
Comment 1 Alexey Proskuryakov 2015-11-17 18:08:30 PST
Created attachment 265725 [details]
proposed fix
Comment 2 Antti Koivisto 2015-11-17 21:27:52 PST
Comment on attachment 265725 [details]
proposed fix

Nice, thanks!
Comment 3 WebKit Commit Bot 2015-11-17 22:14:24 PST
Comment on attachment 265725 [details]
proposed fix

Rejecting attachment 265725 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265725, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
151376.
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
 http://webkit.org/coding/contributing.html
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/444229
Comment 4 Alexey Proskuryakov 2015-11-17 22:27:33 PST
Oops. Landed manually in http://trac.webkit.org/r192565