Bug 151374 - Web Inspector: Update Timeline UI based on the Instruments in the Active Recording
Summary: Web Inspector: Update Timeline UI based on the Instruments in the Active Reco...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-17 17:17 PST by Joseph Pecoraro
Modified: 2015-12-01 13:56 PST (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (14.30 KB, patch)
2015-11-17 17:22 PST, Joseph Pecoraro
bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-11-17 17:17:06 PST
* SUMMARY
Update Timeline UI based on the Instruments in the Active Recording.

Dynamically update the Timeline UI based on the Instruments in the Active Recording.

    - load a new Timeline with Network/Layout instruments
      => TimelineOverview should have 2 rows and not offer RenderingFrames view of time (basic toolbar)

    - load a new Timeline with Network/Layout/Scripts/FPS instruments
      => TimelineOverview should have 3 rows, and offer RenderingFrames view of time (toggle toolbar)

There isn't yet UI to change the instruments used by Timelines, but this ensures the UI updates properly.
Comment 1 Radar WebKit Bug Importer 2015-11-17 17:17:41 PST
<rdar://problem/23586487>
Comment 2 Joseph Pecoraro 2015-11-17 17:22:06 PST
Created attachment 265720 [details]
[PATCH] Proposed Fix

I don't expect this to build, it relies on earlier patches.
Comment 3 BJ Burg 2015-11-18 16:54:24 PST
Comment on attachment 265720 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265720&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:841
> +        const timelineHeight = 36;

FIXME: this will (hopefully) (eventually) be dynamically resizable per timeline. Important once we have graphs and not pills.
Comment 4 Joseph Pecoraro 2015-12-01 13:56:36 PST
<http://trac.webkit.org/changeset/192907>