Bug 151374 – Web Inspector: Update Timeline UI based on the Instruments in the Active Recording

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Update Timeline UI based on the Instruments in the Active Recording.

Dynamically update the Timeline UI based on the Instruments in the Active Recording.

    - load a new Timeline with Network/Layout instruments
      => TimelineOverview should have 2 rows and not offer RenderingFrames view of time (basic toolbar)

    - load a new Timeline with Network/Layout/Scripts/FPS instruments
      => TimelineOverview should have 3 rows, and offer RenderingFrames view of time (toggle toolbar)

There isn't yet UI to change the instruments used by Timelines, but this ensures the UI updates properly.

[Radar WebKit Bug Importer]

<rdar://problem/23586487>

[Joseph Pecoraro]

Created attachment 265720 [details]
[PATCH] Proposed Fix

I don't expect this to build, it relies on earlier patches.

[Blaze Burg]

Comment on attachment 265720 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265720&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:841
> +        const timelineHeight = 36;

FIXME: this will (hopefully) (eventually) be dynamically resizable per timeline. Important once we have graphs and not pills.

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/192907>