Bug 151358 - Refactoring: move branchMul32's imm arg to the 3rd argument to be consistent.
Summary: Refactoring: move branchMul32's imm arg to the 3rd argument to be consistent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-17 13:59 PST by Mark Lam
Modified: 2015-11-17 14:09 PST (History)
4 users (show)

See Also:


Attachments
proposed patch. (7.85 KB, patch)
2015-11-17 14:04 PST, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-11-17 13:59:23 PST
branch32, branchAdd32, and branchSub32 all have it as the 3rd argument.  branchMul32 is the odd man out.
Comment 1 Mark Lam 2015-11-17 14:04:07 PST
Created attachment 265706 [details]
proposed patch.
Comment 2 Mark Lam 2015-11-17 14:04:57 PST
I've already built this patch successfully for ARMv7, ARM64, x86 and x86_64.
Comment 3 Saam Barati 2015-11-17 14:06:24 PST
Comment on attachment 265706 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2015-11-17 14:09:40 PST
Thanks.  Landed in r192535: <http://trac.webkit.org/r192535>.