Bug 151349 - HTTP authentication dialog should focus on first input field
Summary: HTTP authentication dialog should focus on first input field
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-17 10:31 PST by (bitlord)
Modified: 2017-05-10 07:46 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2017-05-10 07:15 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description (bitlord) 2015-11-17 10:31:48 PST 
This is example from my dsl router, every time I try to open its web interface it ask for authentication, but if you start typing nothing happens, you first need to click into text field to switch focus to it.
On other browsers same dialog and first input field is in focus automatically.
Comment 1 Michael Catanzaro 2015-11-17 10:35:06 PST 
The request is just to focus the username field in the WebKitAuthenticationDialog by default.
Comment 2 Claudio Saavedra 2017-05-10 07:15:50 PDT 
Created attachment 309601 [details]
Patch
Comment 3 Build Bot 2017-05-10 07:18:21 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Michael Catanzaro 2017-05-10 07:32:00 PDT 
Comment on attachment 309601 [details]
Patch

OK. Since this is GTK+, I guess it's probably not possible to add a layout test for this... and it's very minor anyway.
Comment 5 WebKit Commit Bot 2017-05-10 07:46:45 PDT 
Comment on attachment 309601 [details]
Patch

Clearing flags on attachment: 309601

Committed r216584: <http://trac.webkit.org/changeset/216584>
Comment 6 WebKit Commit Bot 2017-05-10 07:46:47 PDT 
All reviewed patches have been landed.  Closing bug.