RESOLVED FIXED Bug 151342
[JSC] Remove FTLOutput operations that act directly on floats 
https://bugs.webkit.org/show_bug.cgi?id=151342
Summary [JSC] Remove FTLOutput operations that act directly on floats
Benjamin Poulain
Reported 2015-11-16 23:06:01 PST
[JSC] Remove FTLOutput operations that act directly on floats
Attachments
Patch (5.09 KB, patch)
2015-11-16 23:06 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-11-16 23:06:15 PST
Created attachment 265665 [details] Patch
Geoffrey Garen
Comment 2 2015-11-17 14:03:03 PST
Comment on attachment 265665 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-11-17 14:48:23 PST
Comment on attachment 265665 [details] Patch Clearing flags on attachment: 265665 Committed r192543: <http://trac.webkit.org/changeset/192543>
WebKit Commit Bot
Comment 4 2015-11-17 14:48:26 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 5 2015-12-09 20:13:08 PST
Comment on attachment 265665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265665&action=review > Source/JavaScriptCore/ftl/FTLOutput.cpp:95 > + if (refType == refFloat) > + value = buildFPCast(m_builder, value, floatType); Is this really needed?
Filip Pizlo
Comment 6 2015-12-09 20:15:51 PST
Actually, seems like we should probably just roll this out now that B3 supports floats!
Note You need to log in before you can comment on or make changes to this bug.