Bug 151334 - Reorganize the graphics benchmark string table
Summary: Reorganize the graphics benchmark string table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-16 17:53 PST by Said Abou-Hallawa
Modified: 2015-11-17 17:29 PST (History)
6 users (show)

See Also:

Attachments
Patch (20.75 KB, patch)
2015-11-16 18:29 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (20.75 KB, patch)
2015-11-17 16:32 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-11-16 17:53:57 PST 
A string table was added to the benchmark to ease the separation of the code from the literal strings. The literal strings are used mainly in the results sections either in the results table or the JSON output. The current string table is an object of sub-string tables. Each sub-string table is an array of strings. Accessing the sub-string table array is cumbersome because it is difficult to know the returned string from its index unless you go back to the string table itself.
Comment 1 Said Abou-Hallawa 2015-11-16 18:29:46 PST 
Created attachment 265648 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-11-17 13:18:53 PST 
Comment on attachment 265648 [details]
Patch

Much nicer!
Comment 3 Said Abou-Hallawa 2015-11-17 16:32:58 PST 
Created attachment 265717 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-17 17:29:20 PST 
Comment on attachment 265717 [details]
Patch

Clearing flags on attachment: 265717

Committed r192559: <http://trac.webkit.org/changeset/192559>
Comment 5 WebKit Commit Bot 2015-11-17 17:29:25 PST 
All reviewed patches have been landed.  Closing bug.