Bug 151312 - Web Inspector: delete-by-word and similar shortcuts should add text to the WebCore kill ring
Summary: Web Inspector: delete-by-word and similar shortcuts should add text to the We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on: 151157
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-16 10:39 PST by BJ Burg
Modified: 2015-11-30 10:35 PST (History)
9 users (show)

See Also:


Attachments
Proposed Fix (6.02 KB, patch)
2015-11-21 12:05 PST, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-11-16 10:39:06 PST
Follow-up work for 151157 to address other uses of kill ring.
Comment 1 BJ Burg 2015-11-21 12:05:09 PST
Created attachment 266030 [details]
Proposed Fix
Comment 2 Radar WebKit Bug Importer 2015-11-21 12:05:32 PST
<rdar://problem/23642146>
Comment 3 Radar WebKit Bug Importer 2015-11-21 12:05:40 PST
<rdar://problem/23642148>
Comment 4 Darin Adler 2015-11-30 10:00:22 PST
Comment on attachment 266030 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=266030&action=review

> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js:44
> +        // FIXME: these keybindings match CodeMirror's default keymap for OS X.
> +        // They should probably be altered for Windows / Linux someday.

Unfortunate to have to hard code these like this. Generally speaking, Safari and WebKit respect the OS X system-wide key bindings <https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/EventOverview/TextDefaultsBindings/TextDefaultsBindings.html>.
Comment 5 WebKit Commit Bot 2015-11-30 10:27:08 PST
Comment on attachment 266030 [details]
Proposed Fix

Clearing flags on attachment: 266030

Committed r192804: <http://trac.webkit.org/changeset/192804>
Comment 6 WebKit Commit Bot 2015-11-30 10:27:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 BJ Burg 2015-11-30 10:29:49 PST
(In reply to comment #4)
> Comment on attachment 266030 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=266030&action=review
> 
> > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js:44
> > +        // FIXME: these keybindings match CodeMirror's default keymap for OS X.
> > +        // They should probably be altered for Windows / Linux someday.
> 
> Unfortunate to have to hard code these like this. Generally speaking, Safari
> and WebKit respect the OS X system-wide key bindings
> <https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/
> EventOverview/TextDefaultsBindings/TextDefaultsBindings.html>.

Wow, I had no idea that this exists! I'll file a bug to see if we can integrate it.