Bug 151289 - Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
Summary: Eliminate a request for layout every time an item is added to the stage of th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-13 18:47 PST by Said Abou-Hallawa
Modified: 2015-11-13 21:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2015-11-13 18:50 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-11-13 18:47:22 PST 
The graphics item usually asks for the stage size when it is created. Because the stage size was not cached but rather was requested via clientWidth and clientHeight an implicit request for layout was invoked. This impact of this bug was very obvious when the benchmark was running with large fixed size in non adaptive mode. This was taking few seconds for benchmark to show the first animation frame.
Comment 1 Said Abou-Hallawa 2015-11-13 18:50:19 PST 
Created attachment 265527 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-13 21:51:28 PST 
Comment on attachment 265527 [details]
Patch

Clearing flags on attachment: 265527

Committed r192455: <http://trac.webkit.org/changeset/192455>
Comment 3 WebKit Commit Bot 2015-11-13 21:51:32 PST 
All reviewed patches have been landed.  Closing bug.