Bug 151287 – Add a test for media control dropoff

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jon Lee]

Add a test for keeping track of when media controls drop off based on the width of the media element.

[Radar WebKit Bug Importer]

<rdar://problem/23544666>

[Jon Lee]

Created attachment 265521 [details]
Patch

[Build Bot]

Comment on attachment 265521 [details]
Patch

Attachment 265521 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/425840

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 265526 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 265521 [details]
Patch

Attachment 265521 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/426660

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 265531 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 265521 [details]
Patch

Attachment 265521 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/426718

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 265532 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Dean Jackson]

Comment on attachment 265521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265521&action=review

I didn't check why the tests are failing.

> LayoutTests/media/controls/inline-elements-dropoff-order.html:65
> +                testsFinished = function() {
> +                    runAirPlayTests();
> +                };

Do you declare testsFinished as a global variable somewhere? This works as is, but might be nicer if we make it a global var.

> LayoutTests/media/controls/inline-elements-dropoff-order.html:112
> +                internals.setMockMediaPlaybackTargetPickerState("Sleepy TV", "DeviceAvailable");

Have we standardized on Sleepy TV? :)

[Jon Lee]

Need to adjust the test for OS's with no wireless playback support.

[Jon Lee]

(In reply to comment #9)
> Comment on attachment 265521 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265521&action=review
> 
> I didn't check why the tests are failing.

Older Mac OSes don't support wireless playback.

> 
> > LayoutTests/media/controls/inline-elements-dropoff-order.html:65
> > +                testsFinished = function() {
> > +                    runAirPlayTests();
> > +                };
> 
> Do you declare testsFinished as a global variable somewhere? This works as
> is, but might be nicer if we make it a global var.
> 
> > LayoutTests/media/controls/inline-elements-dropoff-order.html:112
> > +                internals.setMockMediaPlaybackTargetPickerState("Sleepy TV", "DeviceAvailable");
> 
> Have we standardized on Sleepy TV? :)

Why not? :) I'll change it to something more professional

[Jon Lee]

(In reply to comment #9)
> Comment on attachment 265521 [details]
> Patch

> > LayoutTests/media/controls/inline-elements-dropoff-order.html:65
> > +                testsFinished = function() {
> > +                    runAirPlayTests();
> > +                };
> 
> Do you declare testsFinished as a global variable somewhere? This works as
> is, but might be nicer if we make it a global var.

I'll pull the global vars out and declare them for clarity.

[Jon Lee]

Created attachment 265550 [details]
Patch

[Jon Lee]

Created attachment 265551 [details]
Patch

[Jon Lee]

Created attachment 265552 [details]
Patch

[Jon Lee]

Created attachment 265553 [details]
Patch

[Build Bot]

Comment on attachment 265553 [details]
Patch

Attachment 265553 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/431330

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 265554 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 265553 [details]
Patch

Attachment 265553 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/431332

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 265555 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 265553 [details]
Patch

Attachment 265553 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/431329

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 265556 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Jon Lee]

Created attachment 265557 [details]
Patch

[Eric Carlson]

Comment on attachment 265557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265557&action=review

> LayoutTests/media/controls/inline-elements-dropoff-order.html:21
> +                if (supportsWirelessTargets)
> +                    internals.setMockMediaPlaybackTargetPickerEnabled(false);

Won't this register the native platform picker, and therefore break your test if there are any real ATVs within range of the machine running the test? 

It seems like you might want to change Internals::setMockMediaPlaybackTargetPickerState so you can leave the mock picker registered but configure it to not advertise any devices. For example:

    if (equalIgnoringCase(deviceState, "DeviceAvailable"))
        state = MediaPlaybackTargetContext::OutputDeviceAvailable;
    else if (equalIgnoringCase(deviceState, "DeviceNotAvailable"))
        state = MediaPlaybackTargetContext:: Unavailable;
    else {
        ec = INVALID_ACCESS_ERR;
        return;
    }

and then:

    internals.setMockMediaPlaybackTargetPickerState("Sleepy TV", "DeviceNotAvailable");

[Jon Lee]

Comment on attachment 265557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265557&action=review

>> LayoutTests/media/controls/inline-elements-dropoff-order.html:21
>> +                    internals.setMockMediaPlaybackTargetPickerEnabled(false);
> 
> Won't this register the native platform picker, and therefore break your test if there are any real ATVs within range of the machine running the test? 
> 
> It seems like you might want to change Internals::setMockMediaPlaybackTargetPickerState so you can leave the mock picker registered but configure it to not advertise any devices. For example:
> 
>     if (equalIgnoringCase(deviceState, "DeviceAvailable"))
>         state = MediaPlaybackTargetContext::OutputDeviceAvailable;
>     else if (equalIgnoringCase(deviceState, "DeviceNotAvailable"))
>         state = MediaPlaybackTargetContext:: Unavailable;
>     else {
>         ec = INVALID_ACCESS_ERR;
>         return;
>     }
> 
> and then:
> 
>     internals.setMockMediaPlaybackTargetPickerState("Sleepy TV", "DeviceNotAvailable");

I thought that being unavailable was the default state.

However, I see the value in being explicit, so I'll add this.

[Jon Lee]

Created attachment 265624 [details]
Patch

[Dean Jackson]

Comment on attachment 265624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265624&action=review

> LayoutTests/media/controls/inline-elements-dropoff-order.html:23
> +                if (supportsWirelessTargets) {
> +                    internals.setMockMediaPlaybackTargetPickerEnabled(false);
> +                    internals.setMockMediaPlaybackTargetPickerState("Wireless playback target", "DeviceNotAvailable");
> +                }

If you check out Internals::Internals() you'll see this:

#if ENABLE(WIRELESS_PLAYBACK_TARGET)
    if (document && document->page())
        document->page()->setMockMediaPlaybackTargetPickerEnabled(true);
#endif

... which means the mock picker is always enabled inside test runs.

But this is actually what we want in this case - setting it to false will mean we'll get the real platform picker.

So I think you can just test for internals, and then setMockMediaPlaybackTargetPickerState("Wireless playback target", "DeviceNotAvailable");

I think that should mean the button will exist, but doesn't have anything to actually pick from. (Since we never select the target, I guess we didn't really need the addition of the DeviceNotAvailable state, but that will be nice to have in the future anyway)

[Jon Lee]

Created attachment 265631 [details]
Patch

[Jon Lee]

(In reply to comment #27)
> Comment on attachment 265624 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265624&action=review
> 
> > LayoutTests/media/controls/inline-elements-dropoff-order.html:23
> > +                if (supportsWirelessTargets) {
> > +                    internals.setMockMediaPlaybackTargetPickerEnabled(false);
> > +                    internals.setMockMediaPlaybackTargetPickerState("Wireless playback target", "DeviceNotAvailable");
> > +                }
> 
> If you check out Internals::Internals() you'll see this:
> 
> #if ENABLE(WIRELESS_PLAYBACK_TARGET)
>     if (document && document->page())
>         document->page()->setMockMediaPlaybackTargetPickerEnabled(true);
> #endif
> 
> ... which means the mock picker is always enabled inside test runs.
> 
> But this is actually what we want in this case - setting it to false will
> mean we'll get the real platform picker.
> 
> So I think you can just test for internals, and then
> setMockMediaPlaybackTargetPickerState("Wireless playback target",
> "DeviceNotAvailable");
> 
> I think that should mean the button will exist, but doesn't have anything to
> actually pick from. (Since we never select the target, I guess we didn't
> really need the addition of the DeviceNotAvailable state, but that will be
> nice to have in the future anyway)

Offline: setting the Enabled setting to false makes it possible to switch to using the native wireless environment than the mock one. So setting picker state will make Internals use the mock environment with no devices available.

[Dean Jackson]

Comment on attachment 265631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265631&action=review

> Source/WebCore/ChangeLog:28
> +        * testing/Internals.cpp: Update to use a reference to Page.

Nice.

> LayoutTests/media/controls/inline-elements-dropoff-order.html:10
> +            var supportsWirelessTargets = !!internals.setMockMediaPlaybackTargetPickerEnabled;

I know we say this only works in DRT, but maybe this line can be removed and....

> LayoutTests/media/controls/inline-elements-dropoff-order.html:21
> +                if (supportsWirelessTargets)
> +                    internals.setMockMediaPlaybackTargetPickerState("Wireless playback target", "DeviceNotAvailable");

... this can just be if (window.internals). That way when running in Safari we won't get an exception right away.

I should have noted this originally, sorry.

> LayoutTests/media/controls/inline-elements-dropoff-order.html:71
> +                    if (supportsWirelessTargets)

And I guess this would be if (window.internals) too.

[Jon Lee]

Comment on attachment 265631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265631&action=review

>> LayoutTests/media/controls/inline-elements-dropoff-order.html:21
>> +                    internals.setMockMediaPlaybackTargetPickerState("Wireless playback target", "DeviceNotAvailable");
> 
> ... this can just be if (window.internals). That way when running in Safari we won't get an exception right away.
> 
> I should have noted this originally, sorry.

"if (window.internals)" will end up breaking Yosemite and older. I'd expect supportsWirelessTargets to evaluate to false on those OSes.

[WebKit Commit Bot]

Comment on attachment 265631 [details]
Patch

Clearing flags on attachment: 265631

Committed r192622: <http://trac.webkit.org/changeset/192622>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

media/controls/inline-elements-dropoff-order.html is failing on mac-wk1

El Capitan:
<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/1402>

Mavericks:
<https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20(Tests)/builds/17146>

[Ryan Haddad]

(In reply to comment #34)
> media/controls/inline-elements-dropoff-order.html is failing on mac-wk1
> 
> El Capitan:
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/1402>
> 
> Mavericks:
> <https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20(Tests)/
> builds/17146>

Also failing on El Capitan Debug WK2:
<https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r192626%20(1213)/results.html>

[Alexey Proskuryakov]

Let's roll it out? Not much use skipping a new test.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 151446

[Eric Carlson]

Created attachment 282894 [details]
Proposed patch.

[Antoine Quint]

Comment on attachment 282894 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=282894&action=review

> LayoutTests/media/controls/inline-elements-dropoff-order.html:65
> +                }, 100);

I think it would be clearer to use a "resize" event handler followed by a requestAnimationFrame() to make sure that a layout has happened as a result of a resize for the controls.

[Build Bot]

Comment on attachment 282894 [details]
Proposed patch.

Attachment 282894 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1636136

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282898 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282894 [details]
Proposed patch.

Attachment 282894 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1636142

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282899 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282894 [details]
Proposed patch.

Attachment 282894 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1636144

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282900 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 282917 [details]
Updated patch for the bots.

[Build Bot]

Comment on attachment 282917 [details]
Updated patch for the bots.

Attachment 282917 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1636934

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282924 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282917 [details]
Updated patch for the bots.

Attachment 282917 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1636954

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282927 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282917 [details]
Updated patch for the bots.

Attachment 282917 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1636963

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282930 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 282936 [details]
Another updated patch for the bots.

[Build Bot]

Comment on attachment 282936 [details]
Another updated patch for the bots.

Attachment 282936 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1637310

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282939 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282936 [details]
Another updated patch for the bots.

Attachment 282936 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1637318

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282940 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282936 [details]
Another updated patch for the bots.

Attachment 282936 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1637314

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282943 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 282967 [details]
Another updated patch for the bots.

[Build Bot]

Comment on attachment 282967 [details]
Another updated patch for the bots.

Attachment 282967 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1638245

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282972 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282967 [details]
Another updated patch for the bots.

Attachment 282967 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1638283

New failing tests:
media/controls/inline-elements-dropoff-order.html

[Build Bot]

Created attachment 282974 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 282975 [details]
One more time for the bots!

[WebKit Commit Bot]

Comment on attachment 282975 [details]
One more time for the bots!

Clearing flags on attachment: 282975

Committed r202905: <http://trac.webkit.org/changeset/202905>

[Ryan Haddad]

(In reply to comment #66)
> Comment on attachment 282975 [details]
> One more time for the bots!
> 
> Clearing flags on attachment: 282975
> 
> Committed r202905: <http://trac.webkit.org/changeset/202905>

media/controls/inline-elements-dropoff-order.html is failing on El Capitan bots:

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r202906%20(7428)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols%2Finline-elements-dropoff-order.html

[Eric Carlson]

Plus https://trac.webkit.org/r202911 to add El Capitan-specific test results.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 159522

[Ryan Haddad]

(In reply to comment #69)
> Re-opened since this is blocked by bug 159522

Link to test failure on El Capitan WK1
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r202927%20(7633)/results.html

[Eric Carlson]

Created attachment 283205 [details]
Updated patch.

[Eric Carlson]

Created attachment 283242 [details]
Updated.

[WebKit Commit Bot]

Comment on attachment 283242 [details]
Updated.

Clearing flags on attachment: 283242

Committed r203057: <http://trac.webkit.org/changeset/203057>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Carlson]

Plus r203068 to add El Capitan specific results.