Bug 151284 - Clean referencing the options object in the graphics benchmark
Summary: Clean referencing the options object in the graphics benchmark
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
Depends on:
Reported: 2015-11-13 16:49 PST by Said Abou-Hallawa
Modified: 2015-11-16 15:22 PST (History)
5 users (show)

See Also:

Patch (12.80 KB, patch)
2015-11-13 17:24 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-11-13 16:49:59 PST
Currently the Benchmark object holds two members for the options: Benchmark.options and Benchmark._options. I think one of them we added by mistake assuming the Benchmark does not hold a reference to the options. Also the Animator references the options through the reference it holds to the Benchmark.
Comment 1 Said Abou-Hallawa 2015-11-13 17:24:10 PST
Created attachment 265520 [details]
Comment 2 WebKit Commit Bot 2015-11-16 15:22:19 PST
Comment on attachment 265520 [details]

Clearing flags on attachment: 265520

Committed r192491: <http://trac.webkit.org/changeset/192491>
Comment 3 WebKit Commit Bot 2015-11-16 15:22:22 PST
All reviewed patches have been landed.  Closing bug.