Bug 151283 - Remove the option for animating using setInterval from the graphics benchmark
Summary: Remove the option for animating using setInterval from the graphics benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-13 16:40 PST by Said Abou-Hallawa
Modified: 2015-11-16 19:29 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2015-11-13 16:45 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (2.73 KB, patch)
2015-11-16 14:51 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2015-11-16 17:41 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-11-13 16:40:06 PST 
The setInterval option has never been used in practice and the existing code to support it makes it hard to maintain the requestAnimationFrame option code.
Comment 1 Said Abou-Hallawa 2015-11-13 16:45:05 PST 
Created attachment 265516 [details]
Patch
Comment 2 Darin Adler 2015-11-14 17:23:53 PST 
Comment on attachment 265516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265516&action=review

> PerformanceTests/Animometer/tests/resources/main.js:116
> +        // If result == 0, no more requestAnimationFrame() will be invokced.

Typo here: "invokced" instead of "invoked".
Comment 3 Said Abou-Hallawa 2015-11-16 14:51:39 PST 
Created attachment 265626 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-16 16:11:43 PST 
Comment on attachment 265626 [details]
Patch

Rejecting attachment 265626 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265626, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
088fd743713948cbc21ed53930b5cc1437c
r192490 = 7bcfba0371cd3ecbc45cf6c3cba98bd648e069fe
r192491 = 4ac83a2d03fe019772cd95bba9292f33a499ce74
r192492 = b9b3a173e91fefddd8b6e298cf6a9de3f00d43bf
r192493 = 1cd9265b3689631010463defad5a28c5ea91f9f3
r192494 = db7a98bbffb81226ed816507a6c1fa08888b5803
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/438823
Comment 5 Said Abou-Hallawa 2015-11-16 17:41:06 PST 
Created attachment 265647 [details]
Patch
Comment 6 WebKit Commit Bot 2015-11-16 18:45:55 PST 
The commit-queue encountered the following flaky tests while processing attachment 265647 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2015-11-16 18:46:28 PST 
The commit-queue encountered the following flaky tests while processing attachment 265647 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2015-11-16 19:29:47 PST 
Comment on attachment 265647 [details]
Patch

Clearing flags on attachment: 265647

Committed r192505: <http://trac.webkit.org/changeset/192505>
Comment 9 WebKit Commit Bot 2015-11-16 19:29:51 PST 
All reviewed patches have been landed.  Closing bug.