Bug 151272 - Add identifier strings for a bunch of context menu items
Summary: Add identifier strings for a bunch of context menu items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 151291
Blocks:
  Show dependency tree / graph
 
Reported: 2015-11-13 12:37 PST by Anders Carlsson
Modified: 2015-11-17 02:40 PST (History)
5 users (show)

See Also:

Attachments
Patch (18.63 KB, patch)
2015-11-13 12:39 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (18.71 KB, patch)
2015-11-16 11:03 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (18.71 KB, patch)
2015-11-16 11:29 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-11-13 12:37:49 PST 
Add identifier strings for a bunch of context menu items
Comment 1 Anders Carlsson 2015-11-13 12:39:51 PST 
Created attachment 265489 [details]
Patch
Comment 2 mitz 2015-11-13 13:25:57 PST 
Comment on attachment 265489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265489&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:35
> +NSString * const _WKMenuItemIdentifierDownloadLinkedFile = @"WKMenuItemIdentifierDownloadLinkedFile";

Maybe we should use resource instead of file?

> Source/WebKit2/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:48
> +NSString * const _WKMenuItemIdentifierShowHideMediaControls = @"WKMenuItemIdentifierShowHideMediaControls";
> +NSString * const _WKMenuItemIdentifierToggleFullScreen = @"WKMenuItemIdentifierToggleFullScreen";

What’s the difference between ShowHide and Toggle?
Comment 3 Anders Carlsson 2015-11-13 15:37:38 PST 
Committed r192445: <http://trac.webkit.org/changeset/192445>
Comment 4 Alexey Proskuryakov 2015-11-13 19:49:15 PST 
This broke the Mac build (and EWS is red!)

Please fix.
Comment 5 Alexey Proskuryakov 2015-11-13 19:56:56 PST 
Anders is not available to fix, rolling out.
Comment 6 WebKit Commit Bot 2015-11-13 19:58:24 PST 
Re-opened since this is blocked by bug 151291
Comment 7 Anders Carlsson 2015-11-16 11:03:37 PST 
Created attachment 265594 [details]
Patch
Comment 8 Anders Carlsson 2015-11-16 11:29:03 PST 
Created attachment 265602 [details]
Patch
Comment 9 Anders Carlsson 2015-11-16 12:46:20 PST 
Committed r192481: <http://trac.webkit.org/changeset/192481>
Comment 10 Csaba Osztrogonác 2015-11-16 13:15:53 PST 
(In reply to comment #9)
> Committed r192481: <http://trac.webkit.org/changeset/192481>

It broke the Apple Mac cmake build.
Comment 11 Csaba Osztrogonác 2015-11-17 02:39:23 PST 
Comment on attachment 265602 [details]
Patch

Cleared review? from attachment 265602 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Comment 12 Csaba Osztrogonác 2015-11-17 02:40:56 PST 
(In reply to comment #10)
> (In reply to comment #9)
> > Committed r192481: <http://trac.webkit.org/changeset/192481>
> 
> It broke the Apple Mac cmake build.

Just to document, it was fixed by https://trac.webkit.org/changeset/192502