RESOLVED FIXED 151272
Add identifier strings for a bunch of context menu items 
https://bugs.webkit.org/show_bug.cgi?id=151272
Summary Add identifier strings for a bunch of context menu items
Anders Carlsson
Reported 2015-11-13 12:37:49 PST
Add identifier strings for a bunch of context menu items
Attachments
Patch (18.63 KB, patch)
2015-11-13 12:39 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (18.71 KB, patch)
2015-11-16 11:03 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (18.71 KB, patch)
2015-11-16 11:29 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-11-13 12:39:51 PST
Created attachment 265489 [details] Patch
mitz
Comment 2 2015-11-13 13:25:57 PST
Comment on attachment 265489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265489&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:35 > +NSString * const _WKMenuItemIdentifierDownloadLinkedFile = @"WKMenuItemIdentifierDownloadLinkedFile"; Maybe we should use resource instead of file? > Source/WebKit2/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:48 > +NSString * const _WKMenuItemIdentifierShowHideMediaControls = @"WKMenuItemIdentifierShowHideMediaControls"; > +NSString * const _WKMenuItemIdentifierToggleFullScreen = @"WKMenuItemIdentifierToggleFullScreen"; What’s the difference between ShowHide and Toggle?
Anders Carlsson
Comment 3 2015-11-13 15:37:38 PST
Committed r192445: <http://trac.webkit.org/changeset/192445>
Alexey Proskuryakov
Comment 4 2015-11-13 19:49:15 PST
This broke the Mac build (and EWS is red!) Please fix.
Alexey Proskuryakov
Comment 5 2015-11-13 19:56:56 PST
Anders is not available to fix, rolling out.
WebKit Commit Bot
Comment 6 2015-11-13 19:58:24 PST
Re-opened since this is blocked by bug 151291
Anders Carlsson
Comment 7 2015-11-16 11:03:37 PST
Created attachment 265594 [details] Patch
Anders Carlsson
Comment 8 2015-11-16 11:29:03 PST
Created attachment 265602 [details] Patch
Anders Carlsson
Comment 9 2015-11-16 12:46:20 PST
Committed r192481: <http://trac.webkit.org/changeset/192481>
Csaba Osztrogonác
Comment 10 2015-11-16 13:15:53 PST
(In reply to comment #9) > Committed r192481: <http://trac.webkit.org/changeset/192481> It broke the Apple Mac cmake build.
Csaba Osztrogonác
Comment 11 2015-11-17 02:39:23 PST
Comment on attachment 265602 [details] Patch Cleared review? from attachment 265602 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Csaba Osztrogonác
Comment 12 2015-11-17 02:40:56 PST
(In reply to comment #10) > (In reply to comment #9) > > Committed r192481: <http://trac.webkit.org/changeset/192481> > > It broke the Apple Mac cmake build. Just to document, it was fixed by https://trac.webkit.org/changeset/192502
Note You need to log in before you can comment on or make changes to this bug.