Add SPI for handling inline link navigation for peek/pop rdar://problem/22233739
Created attachment 265492 [details] Patch
Attachment 265492 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfo.mm:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 265492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265492&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:40 > +@class _WKPreviewingElementInfo; “previewing element” sound a little weird, because the element isn’t doing any previewing, it is being previewed perhaps, so maybe _WKPreviewedElementInfo or _WKPreviewableElementInfo fit better. > Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfo.mm:59 > + return _URL.get(); Because BOOL is sometimes just an unsigned char, this will return NO if the URL pointer ends in a 0 byte, so you should !! it or explicitly compare to nil.
(In reply to comment #3) > Comment on attachment 265492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265492&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:40 > > +@class _WKPreviewingElementInfo; > > “previewing element” sound a little weird, because the element isn’t doing > any previewing, it is being previewed perhaps, so maybe > _WKPreviewedElementInfo or _WKPreviewableElementInfo fit better. > That's true. I think that _WKPreviewableElementInfo is the most accurate, but it's a little clumsy, maybe? Maybe it's fine. _WKPreviewedElementInfo sounds past-tense, so I don't like it as much. I changed it to _WKPreviewElementInfo for now, but I could be convinced that _WKPreviewableElementInfo is better. > > Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfo.mm:59 > > + return _URL.get(); > > Because BOOL is sometimes just an unsigned char, this will return NO if the > URL pointer ends in a 0 byte, so you should !! it or explicitly compare to > nil. Oh, yes, thank you!
Created attachment 265500 [details] Patch
Created attachment 265523 [details] Patch
Attachment 265523 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfoInternal.h:32: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKPreviewElementInfo.mm:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 265547 [details] Patch Hopefully the Mac bots will be happier with this patch.
Attachment 265547 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfoInternal.h:32: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKPreviewElementInfo.mm:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks Darin, Anders, and Dan! http://trac.webkit.org/changeset/192486