Bug 151248 - WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from
Summary: WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-12 23:38 PST by Ryuan Choi
Modified: 2015-11-17 10:35 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2015-11-13 00:08 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-11-12 23:38:06 PST 
Like Bug 147873, it may generate std::bad_function_call
Comment 1 Ryuan Choi 2015-11-13 00:08:15 PST 
Created attachment 265472 [details]
Patch
Comment 2 Darin Adler 2015-11-14 18:53:16 PST 
Comment on attachment 265472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265472&action=review

> Source/WebKit2/ChangeLog:9
> +        Like r188287, calling an empty std::function results in a std::bad_function_call
> +        exception being thrown when sendSync is failed.

Fix looks fine. Why no regression test, though?
Comment 3 Ryuan Choi 2015-11-15 04:05:12 PST 
(In reply to comment #2)
> Comment on attachment 265472 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265472&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Like r188287, calling an empty std::function results in a std::bad_function_call
> > +        exception being thrown when sendSync is failed.
> 
> Fix looks fine. Why no regression test, though?

I don't have idea to make a test case that sendSync is failed,
although EFL test case(test_ewk2_view) sometimes raises this exception.
Comment 4 WebKit Commit Bot 2015-11-16 16:27:01 PST 
Comment on attachment 265472 [details]
Patch

Clearing flags on attachment: 265472

Committed r192496: <http://trac.webkit.org/changeset/192496>
Comment 5 WebKit Commit Bot 2015-11-16 16:27:05 PST 
All reviewed patches have been landed.  Closing bug.