Bug 151245 - Web Inspector: Deleting a probe should remove probe breakpoint actions only.
Summary: Web Inspector: Deleting a probe should remove probe breakpoint actions only.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
: 151244 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-12 21:08 PST by Matt Baker
Modified: 2015-11-12 22:03 PST (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (1.63 KB, patch)
2015-11-12 21:11 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-11-12 21:08:04 PST 
* SUMMARY
Deleting a probe should remove probe breakpoint actions only.

* STEPS TO REPRODUCE
1. Open Debugger tab
2. Create a breakpoint, add a non-probe action (log message) and a probe expression
3. Delete the probe (X) from the Probes panel in the right sidebar
4. Edit breakpoint
  => No breakpoint actions. Expected log message action to still be there
Comment 1 Radar WebKit Bug Importer 2015-11-12 21:08:27 PST 
<rdar://problem/23529750>
Comment 2 Matt Baker 2015-11-12 21:11:34 PST 
Created attachment 265466 [details]
[Patch] Proposed Fix
Comment 3 BJ Burg 2015-11-12 21:13:53 PST 
Comment on attachment 265466 [details]
[Patch] Proposed Fix

Ugh, this should have had a test initially. I won't burden this fix.

r=me
Comment 4 Matt Baker 2015-11-12 21:22:15 PST 
*** Bug 151244 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Commit Bot 2015-11-12 22:03:23 PST 
Comment on attachment 265466 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 265466

Committed r192408: <http://trac.webkit.org/changeset/192408>
Comment 6 WebKit Commit Bot 2015-11-12 22:03:25 PST 
All reviewed patches have been landed.  Closing bug.