Bug 151238 - Style checker script should not mark cq-
Summary: Style checker script should not mark cq-
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-12 17:13 PST by Geoffrey Garen
Modified: 2015-11-12 22:07 PST (History)
7 users (show)

See Also:

Attachments
try it out (448 bytes, text/plain)
2015-11-12 17:24 PST, Geoffrey Garen 		no flags Details
try it out (448 bytes, patch)
2015-11-12 17:24 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
try it out (506 bytes, patch)
2015-11-12 17:28 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-11-12 17:13:54 PST 
Because the style checker is not very reliable, and it will get in the way of broader commit queue usage.
Comment 1 Geoffrey Garen 2015-11-12 17:24:17 PST 
Created attachment 265455 [details]
try it out
Comment 2 Geoffrey Garen 2015-11-12 17:24:56 PST 
Created attachment 265456 [details]
try it out
Comment 3 Geoffrey Garen 2015-11-12 17:28:11 PST 
Created attachment 265458 [details]
try it out
Comment 4 WebKit Commit Bot 2015-11-12 17:30:12 PST 
Attachment 265458 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/Heap.cpp:123:  this_has_underscores is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2015-11-12 17:31:26 PST 
Looks like this is already policy.