RESOLVED FIXED 151197
Modern IDB: Pipe through cursor functions from client to server 
https://bugs.webkit.org/show_bug.cgi?id=151197
Summary Modern IDB: Pipe through cursor functions from client to server
Brady Eidson
Reported 2015-11-12 10:05:03 PST
Modern IDB: Pipe through cursor functions from client to server The result of all requests will always be an error for now.
Attachments
Patch v1 (111.02 KB, patch)
2015-11-12 15:09 PST, Brady Eidson 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (111.46 KB, patch)
2015-11-12 15:33 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-11-12 10:05:16 PST
(In reply to comment #0) > Modern IDB: Pipe through cursor functions from client to server > > The result of all requests will always be an error for now. Until https://bugs.webkit.org/show_bug.cgi?id=151196 is resolved
Brady Eidson
Comment 2 2015-11-12 15:09:32 PST
Created attachment 265437 [details] Patch v1
Alex Christensen
Comment 3 2015-11-12 15:27:02 PST
Comment on attachment 265437 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=265437&action=review > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:49 > + , m_source(adoptRef(*IDBAny::create(objectStore).leakRef())) can you use wtf::move here, or just *IDBAny::create(objectStore), or make IDBAny::create return a Ref? > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:56 > + , m_source(adoptRef(*IDBAny::create(index).leakRef())) same.
Brady Eidson
Comment 4 2015-11-12 15:30:53 PST
(In reply to comment #3) > Comment on attachment 265437 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265437&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:49 > > + , m_source(adoptRef(*IDBAny::create(objectStore).leakRef())) > > can you use wtf::move here, or just *IDBAny::create(objectStore), or make > IDBAny::create return a Ref? The first two, no. The third, yes. > > > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:56 > > + , m_source(adoptRef(*IDBAny::create(index).leakRef())) > > same. Same.
Brady Eidson
Comment 5 2015-11-12 15:33:35 PST
Created attachment 265441 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-11-12 16:24:13 PST
Comment on attachment 265441 [details] Patch for landing Clearing flags on attachment: 265441 Committed r192396: <http://trac.webkit.org/changeset/192396>
WebKit Commit Bot
Comment 7 2015-11-12 16:24:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.