Bug 151197 - Modern IDB: Pipe through cursor functions from client to server
Summary: Modern IDB: Pipe through cursor functions from client to server
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 151196
  Show dependency tree / graph
 
Reported: 2015-11-12 10:05 PST by Brady Eidson
Modified: 2015-11-12 16:24 PST (History)
2 users (show)

See Also:

Attachments
Patch v1 (111.02 KB, patch)
2015-11-12 15:09 PST, Brady Eidson 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (111.46 KB, patch)
2015-11-12 15:33 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-12 10:05:03 PST 
Modern IDB: Pipe through cursor functions from client to server

The result of all requests will always be an error for now.
Comment 1 Brady Eidson 2015-11-12 10:05:16 PST 
(In reply to comment #0)
> Modern IDB: Pipe through cursor functions from client to server
> 
> The result of all requests will always be an error for now.

Until https://bugs.webkit.org/show_bug.cgi?id=151196 is resolved
Comment 2 Brady Eidson 2015-11-12 15:09:32 PST 
Created attachment 265437 [details]
Patch v1
Comment 3 Alex Christensen 2015-11-12 15:27:02 PST 
Comment on attachment 265437 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=265437&action=review

> Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:49
> +    , m_source(adoptRef(*IDBAny::create(objectStore).leakRef()))

can you use wtf::move here, or just *IDBAny::create(objectStore), or make IDBAny::create return a Ref?

> Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:56
> +    , m_source(adoptRef(*IDBAny::create(index).leakRef()))

same.
Comment 4 Brady Eidson 2015-11-12 15:30:53 PST 
(In reply to comment #3)
> Comment on attachment 265437 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265437&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:49
> > +    , m_source(adoptRef(*IDBAny::create(objectStore).leakRef()))
> 
> can you use wtf::move here, or just *IDBAny::create(objectStore), or make
> IDBAny::create return a Ref?

The first two, no.
The third, yes.

> 
> > Source/WebCore/Modules/indexeddb/client/IDBCursorImpl.cpp:56
> > +    , m_source(adoptRef(*IDBAny::create(index).leakRef()))
> 
> same.

Same.
Comment 5 Brady Eidson 2015-11-12 15:33:35 PST 
Created attachment 265441 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-11-12 16:24:13 PST 
Comment on attachment 265441 [details]
Patch for landing

Clearing flags on attachment: 265441

Committed r192396: <http://trac.webkit.org/changeset/192396>
Comment 7 WebKit Commit Bot 2015-11-12 16:24:17 PST 
All reviewed patches have been landed.  Closing bug.