Bug 151191 – Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

We should support building production configuration of DumpRenderTree and WebKitTestRunner for iOS Simulator just as we do for Mac.

[Daniel Bates]

Created attachment 265393 [details]
Patch

[Daniel Bates]

Created attachment 265399 [details]
Patch

[Dana Burkart]

Comment on attachment 265399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265399&action=review

> Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm:37
> +int main(int, char*[])

For consistency, shouldn't this method signature match the one above? Like:

int main(int argc, const char *argv[])

> Tools/WebKitTestRunner/mac/main.mm:68
> +int main(int, char*[])

Ditto.

[Daniel Bates]

(In reply to comment #3)
> Comment on attachment 265399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265399&action=review
> 
> > Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm:37
> > +int main(int, char*[])
> 
> For consistency, shouldn't this method signature match the one above? Like:
> 
> int main(int argc, const char *argv[])
> 

Will fix.

> > Tools/WebKitTestRunner/mac/main.mm:68
> > +int main(int, char*[])
> 
> Ditto.

Will fix.

[Daniel Bates]

Created attachment 265405 [details]
Patch

[Daniel Bates]

Comment on attachment 265405 [details]
Patch

Clearing flags on attachment: 265405

Committed r192375: <http://trac.webkit.org/changeset/192375>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.