Bug 151191 - Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
Summary: Support building configuration Production of DumpRenderTree and WebKitTestRun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Mac OS X 10.11
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-12 07:56 PST by Daniel Bates
Modified: 2015-11-12 12:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (15.78 KB, patch)
2015-11-12 07:57 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (6.79 KB, patch)
2015-11-12 08:46 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (10.10 KB, patch)
2015-11-12 10:18 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-11-12 07:56:18 PST 
We should support building production configuration of DumpRenderTree and WebKitTestRunner for iOS Simulator just as we do for Mac.
Comment 1 Daniel Bates 2015-11-12 07:57:04 PST 
Created attachment 265393 [details]
Patch
Comment 2 Daniel Bates 2015-11-12 08:46:17 PST 
Created attachment 265399 [details]
Patch
Comment 3 Dana Burkart 2015-11-12 09:31:09 PST 
Comment on attachment 265399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265399&action=review

> Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm:37
> +int main(int, char*[])

For consistency, shouldn't this method signature match the one above? Like:

int main(int argc, const char *argv[])

> Tools/WebKitTestRunner/mac/main.mm:68
> +int main(int, char*[])

Ditto.
Comment 4 Daniel Bates 2015-11-12 10:08:33 PST 
(In reply to comment #3)
> Comment on attachment 265399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265399&action=review
> 
> > Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm:37
> > +int main(int, char*[])
> 
> For consistency, shouldn't this method signature match the one above? Like:
> 
> int main(int argc, const char *argv[])
> 

Will fix.

> > Tools/WebKitTestRunner/mac/main.mm:68
> > +int main(int, char*[])
> 
> Ditto.

Will fix.
Comment 5 Daniel Bates 2015-11-12 10:18:06 PST 
Created attachment 265405 [details]
Patch
Comment 6 Daniel Bates 2015-11-12 12:02:30 PST 
Comment on attachment 265405 [details]
Patch

Clearing flags on attachment: 265405

Committed r192375: <http://trac.webkit.org/changeset/192375>
Comment 7 Daniel Bates 2015-11-12 12:02:33 PST 
All reviewed patches have been landed.  Closing bug.