Bug 151190 – Clean imported/w3c/web-platform-tests folder

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

During the previous import, tests removed in wpt repo were kept in imported/w3c/web-platform-tests WebKit folder.
We should remove these obsolete tests and their expected-txt files.

[youenn fablet]

Created attachment 265388 [details]
Patch

[youenn fablet]

(In reply to comment #0)
> During the previous import, tests removed in wpt repo were kept in
> imported/w3c/web-platform-tests WebKit folder.
> We should remove these obsolete tests and their expected-txt files.

Some tests that I thought were obsolete are actually tests that have the same filenames except for the extension which can html and xhtml for instance.
This poses an issue to get different -expected.txt files.
We might want to change filenames at the wpt repository.
Then, we might be able to remove those tests.

[youenn fablet]

Created attachment 265392 [details]
Patch

[youenn fablet]

(In reply to comment #3)
> Created attachment 265392 [details]
> Patch

Second patch does not remove empty files found in imported/w3c/web-platform-tests/dom/nodes/resources since it seems EWS has issues applying patch.
I guess the removal of these files should be landed manually.

[Build Bot]

Comment on attachment 265392 [details]
Patch

Attachment 265392 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/419476

New failing tests:
imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-xhtml.xht

[Build Bot]

Created attachment 265395 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 265392 [details]
Patch

Attachment 265392 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/419480

New failing tests:
imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-xhtml.xht

[Build Bot]

Created attachment 265397 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 265392 [details]
Patch

Attachment 265392 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/419472

New failing tests:
imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-xhtml.xht

[Build Bot]

Created attachment 265398 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[youenn fablet]

Created attachment 265480 [details]
Patch

[Chris Dumez]

Comment on attachment 265480 [details]
Patch

rs=me

[youenn fablet]

Created attachment 265577 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 265577 [details]
Patch for landing

Rejecting attachment 265577 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 265577, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
n_dom_03-expected.txt'
patching file LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04-expected.txt
rm 'LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04-expected.txt'
patching file LayoutTests/imported/w3c/web-platform-tests/w3c-import.log

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/436123

[youenn fablet]

Created attachment 265578 [details]
Patch for landing

[youenn fablet]

(In reply to comment #15)
> Created attachment 265578 [details]
> Patch for landing

Removing removal of empty files.

[WebKit Commit Bot]

Comment on attachment 265578 [details]
Patch for landing

Clearing flags on attachment: 265578

Committed r192467: <http://trac.webkit.org/changeset/192467>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

(In reply to comment #16)
> (In reply to comment #15)
> > Created attachment 265578 [details]
> > Patch for landing
> 
> Removing removal of empty files.

Empty files are removed as part of https://trac.webkit.org/changeset/192468