http://trac.webkit.org/changeset/192169 broke the --minimal build: ../../Source/WebCore/rendering/RenderCombineText.cpp: In member function ‘void WebCore::RenderCombineText::combineText()’: ../../Source/WebCore/rendering/RenderCombineText.cpp:185:71: error: variable ‘WTF::NeverDestroyed<WTF::String> objectReplacementCharacterString’ has initializer but incomplete type static NeverDestroyed<String> objectReplacementCharacterString(&objectReplacementCharacter, 1); ^ ninja: build stopped: subcommand failed. The normal build works fine, because some #if guarded header includes NeverDestroyed.h, but RenderCombineText.cpp shouldn't rely on this transitive dependency.
Created attachment 265381 [details] Patch
Comment on attachment 265381 [details] Patch In general we *do* rely on transitive dependencies all the time, but if it’s platform specific, then a fix like this is fine.
Comment on attachment 265381 [details] Patch Clearing flags on attachment: 265381 Committed r192368: <http://trac.webkit.org/changeset/192368>
All reviewed patches have been landed. Closing bug.