RESOLVED FIXED 151186
Fix build failure due to missing NeverDestroyed.h include after r192169 
https://bugs.webkit.org/show_bug.cgi?id=151186
Summary Fix build failure due to missing NeverDestroyed.h include after r192169
Csaba Osztrogonác
Reported 2015-11-12 03:47:09 PST
http://trac.webkit.org/changeset/192169 broke the --minimal build: ../../Source/WebCore/rendering/RenderCombineText.cpp: In member function ‘void WebCore::RenderCombineText::combineText()’: ../../Source/WebCore/rendering/RenderCombineText.cpp:185:71: error: variable ‘WTF::NeverDestroyed<WTF::String> objectReplacementCharacterString’ has initializer but incomplete type static NeverDestroyed<String> objectReplacementCharacterString(&objectReplacementCharacter, 1); ^ ninja: build stopped: subcommand failed. The normal build works fine, because some #if guarded header includes NeverDestroyed.h, but RenderCombineText.cpp shouldn't rely on this transitive dependency.
Attachments
Patch (1.11 KB, patch)
2015-11-12 03:53 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-11-12 03:53:23 PST
Created attachment 265381 [details] Patch
Darin Adler
Comment 2 2015-11-12 09:33:40 PST
Comment on attachment 265381 [details] Patch In general we *do* rely on transitive dependencies all the time, but if it’s platform specific, then a fix like this is fine.
WebKit Commit Bot
Comment 3 2015-11-12 10:21:34 PST
Comment on attachment 265381 [details] Patch Clearing flags on attachment: 265381 Committed r192368: <http://trac.webkit.org/changeset/192368>
WebKit Commit Bot
Comment 4 2015-11-12 10:21:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.