Bug 151185 - Fix build failure due to missing forward declaration of FontVariantSettings after r191968
Summary: Fix build failure due to missing forward declaration of FontVariantSettings a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 149771
  Show dependency treegraph
 
Reported: 2015-11-12 03:35 PST by Csaba Osztrogonác
Modified: 2015-11-12 10:17 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.18 KB, patch)
2015-11-12 03:37 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (1.18 KB, patch)
2015-11-12 03:42 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-11-12 03:35:48 PST
http://trac.webkit.org/changeset/191968 broke the --minimal build.

http://trac.webkit.org/changeset/191968/trunk/Source/WebCore/css/CSSFontFaceSource.h
started using FontVariantSettings type without forward declaration. The full build
works fine, because one of included header declares it (or includes its header),
but CSSFontFaceSource.h shouldn't contain this transitive dependency.

build log:
-----------
In file included from ../../Source/WebCore/css/CSSFontFaceSource.cpp:27:0:
../../Source/WebCore/css/CSSFontFaceSource.h:64:141: error: 'FontVariantSettings' does not name a type
../../Source/WebCore/css/CSSFontFaceSource.cpp:104:14: error: prototype for 'WTF::RefPtr<WebCore::Font> WebCore::CSSFontFaceSource::font(const WebCore::FontDescription&, bool, bool, WebCore::CSSFontSelector*, const WebCore::FontFeatureSettings&, const WebCore::FontVariantSettings&)' does not match any in class 'WebCore::CSSFontFaceSource'
In file included from ../../Source/WebCore/css/CSSFontFaceSource.cpp:27:0:
../../Source/WebCore/css/CSSFontFaceSource.h:64:18: error: candidate is: WTF::RefPtr<WebCore::Font> WebCore::CSSFontFaceSource::font(const WebCore::FontDescription&, bool, bool, WebCore::CSSFontSelector*, const WebCore::FontFeatureSettings&, const int&)
Comment 1 Csaba Osztrogonác 2015-11-12 03:37:28 PST
Created attachment 265379 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-11-12 03:42:07 PST
Created attachment 265380 [details]
Patch
Comment 3 WebKit Commit Bot 2015-11-12 10:17:17 PST
Comment on attachment 265380 [details]
Patch

Clearing flags on attachment: 265380

Committed r192367: <http://trac.webkit.org/changeset/192367>
Comment 4 WebKit Commit Bot 2015-11-12 10:17:22 PST
All reviewed patches have been landed.  Closing bug.