Bug 151176 - [JSC] Add a comment explaining the opcode suffixes on x86
Summary: [JSC] Add a comment explaining the opcode suffixes on x86
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 19:22 PST by Benjamin Poulain
Modified: 2015-11-11 21:19 PST (History)
0 users

See Also:

Attachments
Patch (2.23 KB, patch)
2015-11-11 19:24 PST, Benjamin Poulain 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-11-11 19:22:04 PST 
[JSC] Add a comment explaining the opcode suffixes on x86
Comment 1 Benjamin Poulain 2015-11-11 19:24:08 PST 
Created attachment 265352 [details]
Patch
Comment 2 Alex Christensen 2015-11-11 20:40:28 PST 
Comment on attachment 265352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265352&action=review

I've wondered about the EvGv suffixes, too.

> Source/JavaScriptCore/assembler/X86Assembler.h:181
> +    // The most commons argument types are:

common

> Source/JavaScriptCore/assembler/X86Assembler.h:185
> +    // The most commons sizes are:

common

> Source/JavaScriptCore/assembler/X86Assembler.h:187
> +    //     -z: 32bits in both 32bits and 64bits mode. Common for immediate values.

32bit and 64bit mode
Comment 3 Benjamin Poulain 2015-11-11 21:19:37 PST 
Committed r192348: <http://trac.webkit.org/changeset/192348>