RESOLVED FIXED 151176
[JSC] Add a comment explaining the opcode suffixes on x86 
https://bugs.webkit.org/show_bug.cgi?id=151176
Summary [JSC] Add a comment explaining the opcode suffixes on x86
Benjamin Poulain
Reported 2015-11-11 19:22:04 PST
[JSC] Add a comment explaining the opcode suffixes on x86
Attachments
Patch (2.23 KB, patch)
2015-11-11 19:24 PST, Benjamin Poulain 		achristensen: review+
achristensen: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-11-11 19:24:08 PST
Created attachment 265352 [details] Patch
Alex Christensen
Comment 2 2015-11-11 20:40:28 PST
Comment on attachment 265352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265352&action=review I've wondered about the EvGv suffixes, too. > Source/JavaScriptCore/assembler/X86Assembler.h:181 > + // The most commons argument types are: common > Source/JavaScriptCore/assembler/X86Assembler.h:185 > + // The most commons sizes are: common > Source/JavaScriptCore/assembler/X86Assembler.h:187 > + // -z: 32bits in both 32bits and 64bits mode. Common for immediate values. 32bit and 64bit mode
Benjamin Poulain
Comment 3 2015-11-11 21:19:37 PST
Committed r192348: <http://trac.webkit.org/changeset/192348>
Note You need to log in before you can comment on or make changes to this bug.