Bug 151175 – Web Inspector: Add Debug toolbar button to toggle InspectorBackend.dumpInspectorProtocolMessages

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Add Debug toolbar button to toggle InspectorBackend.dumpInspectorProtocolMessages.

I find myself toggling this many many times a day. Having a UI button to toggle this would be much better.

* NOTES
- Toolbar button should be debug only, not included in Production (minified) builds

[Radar WebKit Bug Importer]

<rdar://problem/23511452>

[Joseph Pecoraro]

Created attachment 265350 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 265351 [details]
[IMAGE] Debug Toolbar Button (Active)

[Joseph Pecoraro]

Comment on attachment 265350 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265350&action=review

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.jsSource/WebInspectorUI/UserInterface/Base/Bootstrap.js:44
> +    WebInspector.showDebugInspectorToolbarButtonSetting = new WebInspector.Setting("show-debug-inspector-toolbar-button", false);
> +    WebInspector.showDebugInspectorToolbarButtonSetting.addEventListener(WebInspector.Setting.Event.Changed, function() {

Brian wants to make this a keyboard shortcut to enable all debug features. Something like (Shift+Option+Cmd+D). That seems fine to me. I'll make a new patch.

[Joseph Pecoraro]

Created attachment 265357 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 265357 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265357&action=review

r=me, thanks.

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js:30
> +    WebInspector.showDebugUI = new WebInspector.Setting("show-debug-ui", false);
> +    new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Option | WebInspector.KeyboardShortcut.Modifier.Shift | WebInspector.KeyboardShortcut.Modifier.CommandOrControl, "D", function() {
> +        WebInspector.showDebugUI.value = !WebInspector.showDebugUI.value;

Please suffix = Setting

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.js:38
> +    debugInspectorToolbarButton.addEventListener(WebInspector.ButtonNavigationItem.Event.Clicked, function() {

use arrow function

[Joseph Pecoraro]

Created attachment 265360 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 265360 [details]
[PATCH] For Landing

Clearing flags on attachment: 265360

Committed r192351: <http://trac.webkit.org/changeset/192351>