Bug 151171 - [JSC] Do not generate an Add when adding a zero immediate to something
Summary: [JSC] Do not generate an Add when adding a zero immediate to something
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 18:07 PST by Benjamin Poulain
Modified: 2016-02-04 14:51 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.59 KB, patch)
2015-11-11 18:07 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (803.16 KB, application/zip)
2015-11-11 19:09 PST, Build Bot 		no flags Details
Patch (11.46 KB, patch)
2015-11-12 17:44 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-11-11 18:07:05 PST 
[JSC] Do not generate an Add when adding a zero immedate to something
Comment 1 Benjamin Poulain 2015-11-11 18:07:35 PST 
Created attachment 265343 [details]
Patch
Comment 2 Geoffrey Garen 2015-11-11 18:27:38 PST 
Comment on attachment 265343 [details]
Patch

r=me
Comment 3 Build Bot 2015-11-11 19:09:34 PST 
Comment on attachment 265343 [details]
Patch

Attachment 265343 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/417081

New failing tests:
js/regress/ArrayBuffer-Int32Array-byteOffset.html
Comment 4 Build Bot 2015-11-11 19:09:36 PST 
Created attachment 265349 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Benjamin Poulain 2015-11-12 17:44:39 PST 
Created attachment 265459 [details]
Patch
Comment 6 Geoffrey Garen 2015-11-12 17:55:18 PST 
Comment on attachment 265459 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2015-11-12 22:13:12 PST 
Comment on attachment 265459 [details]
Patch

Clearing flags on attachment: 265459

Committed r192409: <http://trac.webkit.org/changeset/192409>
Comment 8 WebKit Commit Bot 2015-11-12 22:13:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Filip Pizlo 2016-02-04 14:51:25 PST 
This change is invalid.  add32() is also used to zero-extend the value.

I don't think it makes sense to try to audit all of the places that rely on add32() for zero extension, there are probably many of them.