Bug 151168 – Rename handle.*Event to dispatch.*Event

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Rename handle.*Event to dispatch.*Event

[Geoffrey Garen]

Created attachment 265336 [details]
Patch

[Chris Dumez]

Comment on attachment 265336 [details]
Patch

r=me

[Geoffrey Garen]

Comment on attachment 265336 [details]
Patch

Go go Gadget Commit Queue.

[WebKit Commit Bot]

Comment on attachment 265336 [details]
Patch

Clearing flags on attachment: 265336

Committed r192342: <http://trac.webkit.org/changeset/192342>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 265336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265336&action=review

> Source/WebCore/loader/DocumentLoader.h:142
> +        void dispatchOnloadEvents();
> +        bool wasOnloadDispatched() { return m_wasOnloadDispatched; }

These are not good function names. The events are “load” events. There is no standard “onload” event, although a webpage could create and dispatch an event with that name, although there would be no point. There are some attributes named "onload" that set up handlers for "load" events.

I’m also unclear why “event” here is plural. Maybe there is more than one load event that gets dispatched?

> Source/WebCore/loader/DocumentLoader.h:391
> +        bool m_wasOnloadDispatched;

Ditto.

> Source/WebCore/loader/EmptyClients.h:274
> +    virtual void dispatchDidDispatchOnloadEvents() override { }

Ditto.

> Source/WebCore/loader/FrameLoader.h:215
> +    void dispatchOnloadEvents();

Ditto.

> Source/WebCore/loader/FrameLoaderClient.h:155
> +        virtual void dispatchDidDispatchOnloadEvents() = 0;

Ditto.