Bug 151159 - Add ability to insert probes in LLVM IR that we generate.
Summary: Add ability to insert probes in LLVM IR that we generate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 15:17 PST by Mark Lam
Modified: 2015-11-11 16:41 PST (History)
1 user (show)

See Also:


Attachments
the patch. (6.51 KB, patch)
2015-11-11 15:22 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-11-11 15:17:09 PST
This is done by inserting a stackmap intrinsic and emitting the probe there.
Comment 1 Mark Lam 2015-11-11 15:22:05 PST
Created attachment 265322 [details]
the patch.
Comment 2 WebKit Commit Bot 2015-11-11 15:24:33 PST
Attachment 265322 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:9401:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:181:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/ftl/FTLInlineCacheDescriptor.h:190:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-11-11 15:53:15 PST
Comment on attachment 265322 [details]
the patch.

r=me
Comment 4 WebKit Commit Bot 2015-11-11 16:41:12 PST
Comment on attachment 265322 [details]
the patch.

Clearing flags on attachment: 265322

Committed r192334: <http://trac.webkit.org/changeset/192334>
Comment 5 WebKit Commit Bot 2015-11-11 16:41:14 PST
All reviewed patches have been landed.  Closing bug.