Bug 151148 - Assignment to new.target should be an early error
Summary: Assignment to new.target should be an early error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-11 12:13 PST by Ryosuke Niwa
Modified: 2016-03-10 11:42 PST (History)
12 users (show)

See Also:

Attachments
patch (8.49 KB, patch)
2016-03-09 23:48 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (9.18 KB, patch)
2016-03-10 00:08 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Saam Barati 2016-03-09 23:48:53 PST 
Created attachment 273545 [details]
patch
Comment 2 WebKit Commit Bot 2016-03-09 23:51:12 PST 
Attachment 273545 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Parser.cpp:3043:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:4012:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:4024:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/parser/Parser.cpp:4038:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2016-03-10 00:06:34 PST 
Comment on attachment 273545 [details]
patch

r=me
Comment 4 Saam Barati 2016-03-10 00:08:52 PST 
Created attachment 273546 [details]
patch for landing

thanks for the review.
Here is an updated patch that I will land later.
It updates the stress/new-target.js file because that
test no longer parses!
Comment 5 Saam Barati 2016-03-10 11:42:48 PST 
landed in:
http://trac.webkit.org/changeset/197947