Bug 151145 – [MediaStream] Reflect media stream tracks as HTMLMediaElement tracks

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Reflect media stream tracks as HTMLMediaElement tracks according to the spec rules.

[Radar WebKit Bug Importer]

<rdar://problem/23503175>

[Eric Carlson]

Created attachment 265319 [details]
Patch for the bots.

[Jer Noble]

Comment on attachment 265319 [details]
Patch for the bots.

View in context: https://bugs.webkit.org/attachment.cgi?id=265319&action=review

r=me, with nits. Also, fails to apply.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:418
> +void updateTracksOfType(HashMap<String, RefT>& trackMap, RealtimeMediaSource::Type trackType, MediaStreamTrackPrivateVector& currentTracks, RefT (*itemFactory)(MediaStreamTrackPrivate&), MediaPlayer* player, void (MediaPlayer::*removedFunction)(PassRefT), void (MediaPlayer::*addedFunction)(PassRefT), std::function<void(RefT, int)> congigureCallback)

SP(congigureCallback).

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:449
> +        congigureCallback(track, index++);

Ditto.

> Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp:247
>  
>  RefPtr<Image> MediaStreamPrivate::currentFrameImage()
>  {
> -    if (!active() && !m_activeVideoTrack)
> +    if (!active() || !m_activeVideoTrack)
>          return nullptr;
>  
>      return m_activeVideoTrack->source()->currentFrameImage();

You should probably add a ChangeLog entry for this.

[Eric Carlson]

Created attachment 265391 [details]
Patch for landing.

[WebKit Commit Bot]

Attachment 265391 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/VideoTrackPrivateMediaStream.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:450:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:466:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:472:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 5 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 265394 [details]
Updated patch for landing

[WebKit Commit Bot]

Comment on attachment 265394 [details]
Updated patch for landing

Clearing flags on attachment: 265394

Committed r192365: <http://trac.webkit.org/changeset/192365>