Bug 151122 – Use different pixel formats for displays that support them

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Use different pixel formats for dipslays that support them

[Simon Fraser (smfr)]

Created attachment 265246 [details]
Patch

[WebKit Commit Bot]

Attachment 265246 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 265246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265246&action=review

> Source/WebCore/ChangeLog:3
> +        Use different pixel formats for dipslays that support them

dipslays

[Simon Fraser (smfr)]

Created attachment 265249 [details]
For EWS

[WebKit Commit Bot]

Attachment 265249 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 265252 [details]
For EWS

[WebKit Commit Bot]

Attachment 265252 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

https://trac.webkit.org/r192284

Comment on attachment 265252 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=265252&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:211
> +        NSLog(@"Surface creation failed for options %@", options);

Not LOG_ERROR?

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:48
> +#if __has_include(<WebKitAdditions/RemoteLayerBackingStoreAdditions.mm>)

We should guard with USE(APPLE_INTERNAL_SDK), not with __has_include, which would just fail silently if the file went missing in the internal SDK.