WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
151122
Use different pixel formats for displays that support them
https://bugs.webkit.org/show_bug.cgi?id=151122
Summary
Use different pixel formats for displays that support them
Simon Fraser (smfr)
Reported
2015-11-10 16:48:37 PST
Use different pixel formats for dipslays that support them
Attachments
Patch
(8.93 KB, patch)
2015-11-10 16:51 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
For EWS
(9.86 KB, patch)
2015-11-10 17:06 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
For EWS
(9.91 KB, patch)
2015-11-10 17:10 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2015-11-10 16:51:53 PST
Created
attachment 265246
[details]
Patch
WebKit Commit Bot
Comment 2
2015-11-10 16:53:24 PST
Attachment 265246
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2015-11-10 16:59:51 PST
Comment on
attachment 265246
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=265246&action=review
> Source/WebCore/ChangeLog:3 > + Use different pixel formats for dipslays that support them
dipslays
Simon Fraser (smfr)
Comment 4
2015-11-10 17:06:54 PST
Created
attachment 265249
[details]
For EWS
WebKit Commit Bot
Comment 5
2015-11-10 17:08:50 PST
Attachment 265249
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 6
2015-11-10 17:10:55 PST
Created
attachment 265252
[details]
For EWS
WebKit Commit Bot
Comment 7
2015-11-10 17:12:51 PST
Attachment 265252
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/cocoa/IOSurface.h:45: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 8
2015-11-10 17:32:09 PST
https://trac.webkit.org/r192284
mitz
Comment 9
2015-11-10 21:53:47 PST
Comment on
attachment 265252
[details]
For EWS View in context:
https://bugs.webkit.org/attachment.cgi?id=265252&action=review
> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:211 > + NSLog(@"Surface creation failed for options %@", options);
Not LOG_ERROR?
> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:48 > +#if __has_include(<WebKitAdditions/RemoteLayerBackingStoreAdditions.mm>)
We should guard with USE(APPLE_INTERNAL_SDK), not with __has_include, which would just fail silently if the file went missing in the internal SDK.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug