Bug 151118 - Web Inspector: Zooming in on the Timeline should always zoom right where the cursor is
Summary: Web Inspector: Zooming in on the Timeline should always zoom right where the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-10 13:58 PST by Joseph Pecoraro
Modified: 2016-12-14 14:05 PST (History)
5 users (show)

See Also:

Attachments
[Video] With fix applied (747.26 KB, video/mp4)
2016-12-14 13:10 PST, Matt Baker 		no flags Details
Patch (2.91 KB, patch)
2016-12-14 13:14 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-11-10 13:58:46 PST 
* SUMMARY
Zooming in on the Timeline should always zoom right where the cursor is.

Currently, if the Timeline shows a time range greater than the duration between the first and last record we zoom in / out the entire Timeline pinned to the start edge. This zooming behavior is rather annoying when you only want to zoom in on a particular spot and suddenly your cursor doesn't match where you zoomed.

* STEPS TO REPRODUCE
1. Inspect daringfireball.net
2. Show Timeline Tab
3. Reload => records a timeline of ~3 seconds but a timeline range of ~11s.
4. Move mouse over the 1s mark
5. Attempt to zoom in
  => expected 1s to stay where the cursor was, instead it slide over significantly

* NOTES
- Once you've zoomed in enough, if you unpin from the left edge (scroll right a bit) then zoom at a specific point it will get the desired zoom behavior.
Comment 1 Radar WebKit Bug Importer 2015-11-10 13:59:11 PST 
<rdar://problem/23487912>
Comment 2 Matt Baker 2016-12-14 13:10:46 PST 
Created attachment 297116 [details]
[Video] With fix applied
Comment 3 Matt Baker 2016-12-14 13:14:06 PST 
Created attachment 297117 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-14 14:05:00 PST 
Comment on attachment 297117 [details]
Patch

Clearing flags on attachment: 297117

Committed r209834: <http://trac.webkit.org/changeset/209834>
Comment 5 WebKit Commit Bot 2016-12-14 14:05:04 PST 
All reviewed patches have been landed.  Closing bug.