Bug 151115 – B3 should be able to compile a program with Switch

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Thingy.

[Filip Pizlo]

Created attachment 265314 [details]
work in progress

[Filip Pizlo]

Created attachment 265348 [details]
the patch

[WebKit Commit Bot]

Attachment 265348 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3SwitchValue.cpp:68:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3LowerMacros.cpp:182:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 265348 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265348&action=review

> Source/JavaScriptCore/b3/B3BasicBlock.cpp:65
>      proc.deleteValue(last());

removeLast(proc)
?

[Filip Pizlo]

(In reply to comment #4)
> Comment on attachment 265348 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265348&action=review
> 
> > Source/JavaScriptCore/b3/B3BasicBlock.cpp:65
> >      proc.deleteValue(last());
> 
> removeLast(proc)
> ?

Then I'd have to change the next line to be append().  Is that what you are suggesting?

[Benjamin Poulain]

(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 265348 [details]
> > the patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=265348&action=review
> > 
> > > Source/JavaScriptCore/b3/B3BasicBlock.cpp:65
> > >      proc.deleteValue(last());
> > 
> > removeLast(proc)
> > ?
> 
> Then I'd have to change the next line to be append().  Is that what you are
> suggesting?

Yep.
But that's just a pass-by comment. Feel free to ignore.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/192346