Bug 151110 - [WK2][NetworkCache] Rename SpeculativeLoader to SpeculativeLoadManager
Summary: [WK2][NetworkCache] Rename SpeculativeLoader to SpeculativeLoadManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-10 10:39 PST by Chris Dumez
Modified: 2015-11-10 11:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (26.99 KB, patch)
2015-11-10 10:42 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.71 KB, patch)
2015-11-10 10:51 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-11-10 10:39:18 PST 
Rename SpeculativeLoader to SpeculativeLoadManager for clarity, as it manages all speculative loads.
Comment 1 Chris Dumez 2015-11-10 10:42:57 PST 
Created attachment 265198 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-10 10:45:37 PST 
Attachment 265198 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:61:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2015-11-10 10:51:23 PST 
Created attachment 265199 [details]
Patch
Comment 4 WebKit Commit Bot 2015-11-10 10:52:43 PST 
Attachment 265199 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:61:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2015-11-10 11:20:29 PST 
Comment on attachment 265199 [details]
Patch

Clearing flags on attachment: 265199

Committed r192258: <http://trac.webkit.org/changeset/192258>
Comment 6 Chris Dumez 2015-11-10 11:20:35 PST 
All reviewed patches have been landed.  Closing bug.