[Streams API] Shield bind call
Created attachment 265193 [details]
As I said in bug 151089, I am unsure whether we should support @bind or just an inlined polyfill of it. Also @apply and @call are special cased. Should @bind follow the same path?
Created attachment 265275 [details]
(In reply to comment #2)
> As I said in bug 151089, I am unsure whether we should support @bind or just
> an inlined polyfill of it. Also @apply and @call are special cased. Should
> @bind follow the same path?
I might have taken your comment at bug 151089 too literally.
I created an inline function to remove the use of bind.
About making it a special case as @apply and @call I am not sure if it makes sense now. If we do this, I think we could do a longer review of all things done at the builtins because there are probably similar things.
Created attachment 265277 [details]
Reuploaded the right patch.
Created attachment 265279 [details]
Comment on attachment 265277 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=265277&action=review
> + [Streams API] Shield bind call
Let's rename the bug to something like "Remove bind usage from streams API".
Since bind/@bind makes stream code more readable, we may want to create a new bug entry to continue discussing whether we should go with a secure @bind, especially if other built-ins plan to use it.
> +PASS Streams and Function: replace bind method in Function prototype
We may want to remove that test since bind is not used anymore
Created attachment 265281 [details]
Patch for landing
Comment on attachment 265281 [details]
Patch for landing
Clearing flags on attachment: 265281
Committed r192309: <http://trac.webkit.org/changeset/192309>
All reviewed patches have been landed. Closing bug.