WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
151103
Remove TestExpectations for deleted http/tests/xmlhttprequest/timeout tests
https://bugs.webkit.org/show_bug.cgi?id=151103
Summary
Remove TestExpectations for deleted http/tests/xmlhttprequest/timeout tests
Ryan Haddad
Reported
2015-11-10 09:09:55 PST
+++ This bug was initially created as a clone of
Bug #151091
+++ Several WebKit XHR timeout tests (in http/tests/xmlhttprequest/timeout/) have more up-to-date versions in imported/w3c/web-platform-tests/XMLHttpRequest. It seems WPT versions are runned more consistently by bots.
Attachments
Patch
(2.85 KB, patch)
2015-11-10 09:16 PST
,
Ryan Haddad
no flags
Details
Formatted Diff
Diff
Patch
(4.46 KB, patch)
2015-11-10 09:18 PST
,
Ryan Haddad
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryan Haddad
Comment 1
2015-11-10 09:10:22 PST
Using this bug to track removing Mac TestExpectations for these deleted tests.
Ryan Haddad
Comment 2
2015-11-10 09:16:50 PST
Created
attachment 265186
[details]
Patch
Ryan Haddad
Comment 3
2015-11-10 09:18:42 PST
Created
attachment 265187
[details]
Patch
Ryan Haddad
Comment 4
2015-11-10 09:19:12 PST
Second patch removes references to these tests that were skipped on win
WebKit Commit Bot
Comment 5
2015-11-10 10:00:39 PST
Comment on
attachment 265187
[details]
Patch Rejecting
attachment 265187
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 265187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: stExpectations.rej patching file LayoutTests/platform/mac-wk2/TestExpectations Hunk #1 FAILED at 274. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-wk2/TestExpectations.rej patching file LayoutTests/platform/win/TestExpectations Hunk #1 FAILED at 555. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/win/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/410938
youenn fablet
Comment 6
2015-11-12 06:59:41 PST
It seems http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html should also be removed from mac-wk2.
youenn fablet
Comment 7
2015-11-13 09:02:34 PST
Need to update mac-wk2 test expectations
Ryan Haddad
Comment 8
2015-11-13 09:13:09 PST
I'll take care of this.
Ryan Haddad
Comment 9
2015-11-13 09:56:36 PST
Removed in
r192430
.
youenn fablet
Comment 10
2015-11-13 09:58:41 PST
(In reply to
comment #9
)
> Removed in
r192430
.
Thanks :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug