Bug 151080 – sub IC does not properly handle exception handling now that try/catch is compiled in the FTL

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Should be an easy fix.

[Saam Barati]

I'm doing a bit of cleanup as part of this patch too.

[Saam Barati]

Created attachment 265250 [details]
WIP

I think this might be the patch.
Need to write some sub tests.

[Saam Barati]

Created attachment 265256 [details]
patch

[WebKit Commit Bot]

Attachment 265256 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:49:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 265256 [details]
patch

What about Add, and/or other snippets?

[Saam Barati]

(In reply to comment #5)
> Comment on attachment 265256 [details]
> patch
> 
> What about Add, and/or other snippets?

They'll need the same treatment once they're introduced in the FTL.

[Geoffrey Garen]

Comment on attachment 265256 [details]
patch

r=me

[Saam Barati]

Created attachment 265490 [details]
patch for landing.

[WebKit Commit Bot]

Attachment 265490 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOSRExit.cpp:49:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 265490 [details]
patch for landing.

Clearing flags on attachment: 265490

Committed r192439: <http://trac.webkit.org/changeset/192439>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.