Bug 151075 – Web Inspector: Provide a way to override the WKWebView remote inspector name

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Provide a way to override the WKWebView remote inspector name.

[Joseph Pecoraro]

<rdar://problem/23475086>

[Joseph Pecoraro]

Created attachment 265140 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Attachment 265140 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:314:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/PageDebuggable.h:57:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Comment on attachment 265140 [details]
[PATCH] Proposed Fix

Is name reported as the Debuggable's title? I don't see a usage at the WK2 or RemoteInspector side. Otherwise, looks fine to me.

[Joseph Pecoraro]

Comment on attachment 265140 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265140&action=review

> Source/WebCore/page/PageDebuggable.cpp:48
>  String PageDebuggable::name() const

This is the use on the RemoteInspector side. When pushing a listing we get the name() of each debuggable.

[Anders Carlsson]

Wouldn't it be better to make this a configuration parameter instead?

[Blaze Burg]

Comment on attachment 265140 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265140&action=review

>> Source/WebCore/page/PageDebuggable.cpp:48
>>  String PageDebuggable::name() const
> 
> This is the use on the RemoteInspector side. When pushing a listing we get the name() of each debuggable.

Oh, missed that. Thanks.

[Blaze Burg]

(In reply to comment #6)
> Wouldn't it be better to make this a configuration parameter instead?

That would work if we know what to name the view and it will never change. But, I think the idea of this patch is to override crappy page names as the pages are loaded into the WKWebView. Joe?

[Tim Horton]

(In reply to comment #8)
> (In reply to comment #6)
> > Wouldn't it be better to make this a configuration parameter instead?
> 
> That would work if we know what to name the view and it will never change.
> But, I think the idea of this patch is to override crappy page names as the
> pages are loaded into the WKWebView. Joe?

Yeah, I think it's very feasible that clients will want to change the name dynamically.

[Joseph Pecoraro]

Are there any open questions?

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/192437>

[Joseph Pecoraro]

Follow-up to add Availability Macros:
<http://trac.webkit.org/changeset/192446>