Bug 151072 - REGRESSION (r189567): Inline controls on Mac are misplaced
Summary: REGRESSION (r189567): Inline controls on Mac are misplaced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 151067
  Show dependency tree / graph
 
Reported: 2015-11-09 17:26 PST by Jon Lee
Modified: 2015-11-10 00:46 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2015-11-09 17:55 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (6.08 KB, patch)
2015-11-09 18:08 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Patch (6.04 KB, patch)
2015-11-09 18:20 PST, Jon Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2015-11-09 17:26:54 PST 
REGRESSION (r189567): Inline controls on Mac are misplaced
Comment 1 Radar WebKit Bug Importer 2015-11-09 17:27:21 PST 
<rdar://problem/23474515>
Comment 2 Jon Lee 2015-11-09 17:55:31 PST 
Created attachment 265130 [details]
Patch
Comment 3 Jon Lee 2015-11-09 18:08:37 PST 
Created attachment 265135 [details]
Patch
Comment 4 Eric Carlson 2015-11-09 18:12:56 PST 
Comment on attachment 265135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265135&action=review

> LayoutTests/media/controls/fullscreen-button-inline-layout.html:14
> +                var currentState = tester.currentState;
> +                tester.test("We are using the apple idiom")

Nit: the local variable isn't necessary.
Comment 5 Jon Lee 2015-11-09 18:20:12 PST 
Created attachment 265137 [details]
Patch
Comment 6 WebKit Commit Bot 2015-11-10 00:46:39 PST 
Comment on attachment 265137 [details]
Patch

Clearing flags on attachment: 265137

Committed r192205: <http://trac.webkit.org/changeset/192205>
Comment 7 WebKit Commit Bot 2015-11-10 00:46:43 PST 
All reviewed patches have been landed.  Closing bug.