Bug 151071 – Web Inspector: Support Gesture Events to zoom in / out of the Timeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Support Gesture Events to zoom in / out of the Timeline.

Use the gesture event's scale property to scale the secondsPerPixel value.

Center like MouseWheel events around the mouse position.

* NOTES
- This still pins to the edge if an edge is available for both mouse wheel and now gesture events. That feels funny, we should make any zoom IN unpin from the edge and just zoom in where the mouse is. Handle this separately.

[Radar WebKit Bug Importer]

<rdar://problem/23474383>

[Joseph Pecoraro]

Created attachment 265125 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

*** Bug 151061 has been marked as a duplicate of this bug. ***

[Matt Baker]

Comment on attachment 265125 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=265125&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:494
> +        let newSecondsPerPixel = this._gestureStartDurationPerPixel * (1 / scale);

let newSecondsPerPixel = this._gestureStartDurationPerPixel / scale;

[Joseph Pecoraro]

Created attachment 265139 [details]
[PATCH] For Landing

[Joseph Pecoraro]

(In reply to comment #4)
> Comment on attachment 265125 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265125&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:494
> > +        let newSecondsPerPixel = this._gestureStartDurationPerPixel * (1 / scale);
> 
> let newSecondsPerPixel = this._gestureStartDurationPerPixel / scale;

Heh, yeah. I think this is a bit harder to reason about when you read the line of code. In any case, I made this change.

[WebKit Commit Bot]

Comment on attachment 265139 [details]
[PATCH] For Landing

Clearing flags on attachment: 265139

Committed r192198: <http://trac.webkit.org/changeset/192198>

[Blaze Burg]

Comment on attachment 265125 [details]
[PATCH] Proposed Fix

Clearing stale cq? flag.

[Blaze Burg]

Comment on attachment 265139 [details]
[PATCH] For Landing

View in context: https://bugs.webkit.org/attachment.cgi?id=265139&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:429
> +        // Ignore wheel events while handing gestures.

Nit: handling