Bug 151070 - Add WKWebViewConfiguration SPI for a variety of different ex-preferences
Summary: Add WKWebViewConfiguration SPI for a variety of different ex-preferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-09 17:16 PST by Tim Horton
Modified: 2015-11-10 10:06 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.43 KB, patch)
2015-11-09 17:16 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2015-11-09 17:25 PST, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-11-09 17:16:23 PST 
Add WKWebViewConfiguration SPI for a variety of different ex-preferences
Comment 1 Tim Horton 2015-11-09 17:16:43 PST 
Created attachment 265124 [details]
Patch
Comment 2 Tim Horton 2015-11-09 17:25:07 PST 
Created attachment 265127 [details]
Patch
Comment 3 Anders Carlsson 2015-11-09 17:39:00 PST 
Comment on attachment 265127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265127&action=review

I thought we put getters before setters. Please change this if that's the case.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:-55
> -@property (nonatomic, strong, setter=_setVisitedLinkProvider:) _WKVisitedLinkProvider *_visitedLinkProvider WK_DEPRECATED(10_10, WK_MAC_TBA, 8_0, WK_IOS_TBA, "Please use visitedLinkStore instead");
> -
> -@property (nonatomic, strong, setter=_setWebsiteDataStore:) _WKWebsiteDataStore *_websiteDataStore WK_DEPRECATED(10_10, 10_11, 8_0, 9_0, "Please use websiteDataStore instead");

Please move these back so that all deprecated parameters are kept in one place.
Comment 4 Tim Horton 2015-11-10 10:06:55 PST 
http://trac.webkit.org/changeset/192253