Bug 151060 - [EFL] Support an applicationVersion argument to UserAgentEfl::standardUserAgent()
Summary: [EFL] Support an applicationVersion argument to UserAgentEfl::standardUserAge...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-09 16:33 PST by Gyuyoung Kim
Modified: 2015-11-10 19:41 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.50 KB, patch)
2015-11-09 16:37 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.65 KB, patch)
2015-11-10 18:34 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-11-09 16:33:45 PST
*applicationVersion* was missed to support by r192148. This patch adds it as well as missed Darin comments are fixed.
Comment 1 Gyuyoung Kim 2015-11-09 16:37:20 PST
Created attachment 265116 [details]
Patch
Comment 2 Darin Adler 2015-11-10 10:44:15 PST
Comment on attachment 265116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review

> Source/WebCore/platform/efl/UserAgentEfl.cpp:70
> +    String finalApplicationVersion = applicationVersion;

Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary.
Comment 3 Gyuyoung Kim 2015-11-10 17:40:11 PST
Comment on attachment 265116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265116&action=review

>> Source/WebCore/platform/efl/UserAgentEfl.cpp:70
>> +    String finalApplicationVersion = applicationVersion;
> 
> Should do early return if the application name is empty rather than computing an unused string. Probably easier to read than the ?: ternary.

Yes, right. It is more readable !
Comment 4 Gyuyoung Kim 2015-11-10 18:34:02 PST
Created attachment 265258 [details]
Patch
Comment 5 WebKit Commit Bot 2015-11-10 19:41:13 PST
Comment on attachment 265258 [details]
Patch

Clearing flags on attachment: 265258

Committed r192288: <http://trac.webkit.org/changeset/192288>
Comment 6 WebKit Commit Bot 2015-11-10 19:41:16 PST
All reviewed patches have been landed.  Closing bug.