Bug 151056 - Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
Summary: Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-09 15:30 PST by Anders Carlsson
Modified: 2015-11-09 16:05 PST (History)
1 user (show)

See Also:


Attachments
Patch (29.56 KB, patch)
2015-11-09 15:46 PST, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-11-09 15:30:34 PST
Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
Comment 1 Anders Carlsson 2015-11-09 15:46:21 PST
Created attachment 265109 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-09 15:49:07 PST
Attachment 265109 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:263:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:263:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-11-09 15:52:00 PST
Comment on attachment 265109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265109&action=review

> Source/WebKit2/Shared/API/Cocoa/RemoteObjectInvocation.mm:54
> +    encoder << true;

Yikes.
Comment 4 Anders Carlsson 2015-11-09 16:05:27 PST
Committed r192185: <http://trac.webkit.org/changeset/192185>