Bug 151047 - run-jsc-benchmarks doesn't work with internal benchmarks
Summary: run-jsc-benchmarks doesn't work with internal benchmarks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on: 151784
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-09 12:32 PST by Geoffrey Garen
Modified: 2015-12-03 03:13 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2015-11-09 12:32 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-11-09 12:32:08 PST
run-jsc-benchmarks doesn't work with internal benchmarks
Comment 1 Geoffrey Garen 2015-11-09 12:32:59 PST
Created attachment 265080 [details]
Patch
Comment 2 Geoffrey Garen 2015-11-10 14:22:07 PST
Comment on attachment 265080 [details]
Patch

Clearing flags on attachment: 265080

Committed r192271: <http://trac.webkit.org/changeset/192271>
Comment 3 Geoffrey Garen 2015-11-10 14:22:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Carlos Alberto Lopez Perez 2015-11-16 19:21:44 PST
This broke the script for me:

FAILED: #<TypeError: no implicit conversion of nil into String>
Stack trace:
Tools/Scripts/run-jsc-benchmarks:2823:in `initialize'
Tools/Scripts/run-jsc-benchmarks:2823:in `new'
Tools/Scripts/run-jsc-benchmarks:2823:in `<main>'
Use the --help option to get basic usage information.
Comment 5 Csaba Osztrogonác 2015-12-03 03:13:24 PST
(In reply to comment #4)
> This broke the script for me:
> 
> FAILED: #<TypeError: no implicit conversion of nil into String>
> Stack trace:
> Tools/Scripts/run-jsc-benchmarks:2823:in `initialize'
> Tools/Scripts/run-jsc-benchmarks:2823:in `new'
> Tools/Scripts/run-jsc-benchmarks:2823:in `<main>'
> Use the --help option to get basic usage information.

already fixed in bug151047
Comment 6 Csaba Osztrogonác 2015-12-03 03:13:46 PST
I meant bug151784.